Skip to content

[New Rule] Abstract classes MUST NOT be marked as public @api #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Jan 29, 2019 · 1 comment
Closed

[New Rule] Abstract classes MUST NOT be marked as public @api #22

lenaorobei opened this issue Jan 29, 2019 · 1 comment
Assignees
@larsroettig
Labels
accepted New rule is accepted new rule New feature implementation Progress: good first issue Issues is easy to get started with technical guidelines The rule is based on Magento Technical Guidelines

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented Jan 29, 2019 •
edited
Loading

Rule

Abstract classes MUST NOT be marked as public @api.

Reason

Source: Magento Technical Guidelines.

Interfaces should be used instead because Magento follows Composition over Inheritance principle.

Implementation

  • Subscribe to T_CLASS token.
  • Analyse its PHPDoc block and try find @api annotation.
@lenaorobei lenaorobei added proposal New rule proposal new rule New feature implementation labels Jan 29, 2019
@paliarush paliarush added accepted New rule is accepted and removed proposal New rule proposal labels Jan 29, 2019
@lenaorobei lenaorobei added Progress: good first issue Issues is easy to get started with technical guidelines The rule is based on Magento Technical Guidelines labels Jan 30, 2019
@larsroettig larsroettig self-assigned this Mar 3, 2019
larsroettig pushed a commit that referenced this issue Mar 3, 2019
#22: Impl. Abstract classes MUST NOT be marked as public
4f2fd32
@larsroettig larsroettig mentioned this issue Mar 3, 2019
Merged
lenaorobei added a commit that referenced this issue Mar 4, 2019
@lenaorobei
Merge pull request #51 from magento/22-api-abstarct
45a8c6d 
#22: Impl. Abstract classes MUST NOT be marked as public
@lenaorobei
Copy link
Contributor Author

Implemented in #51

magento-devops-reposync-svc pushed a commit that referenced this issue Aug 20, 2021
@sivaschenko
Merge pull request #22 from magento-commerce/imported-magento-magento…
0370887 
…-coding-standard-222

[Imported] Version 7 master update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsroettig larsroettig

Labels
accepted New rule is accepted new rule New feature implementation Progress: good first issue Issues is easy to get started with technical guidelines The rule is based on Magento Technical Guidelines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larsroettig @paliarush @lenaorobei