Prevent none zero exit code #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `composer install --no-dev` the bash command `[ $COMPOSER_DEV_MODE -eq 1]` will cause an exit code of 1. Build environments such as bitbucket piplines will often halt the build when encountering a none zero exit code. To resolve this, we force the exit code to be 0 with some boolean logic.
|
|
lenaorobei
reviewed
Aug 13, 2019
| @@ -12,10 +12,10 @@ You can achieve this by adding the following to your project's `composer.json`: | |||
| ```` | |||
| "scripts": { | |||
| "post-install-cmd": [ | |||
| "[ $COMPOSER_DEV_MODE -eq 1 ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/" | |||
| "([ $COMPOSER_DEV_MODE -eq 1 ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/) || true" | |||
There was a problem hiding this comment.
Suggested change
| "([ $COMPOSER_DEV_MODE -eq 1 ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/) || true" | |
| "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)" |
lenaorobei
reviewed
Aug 13, 2019
lenaorobei
reviewed
Aug 13, 2019
There was a problem hiding this comment.
Please sign Contributor License Agreement and see my suggestions.
|
@lenaorobei As it stands, your suggestion doesn't seem to make much sense. Did you perhaps intend to change the |
|
@pocallaghan, yes, you are absolutely right! I missed that part. |
Co-Authored-By: Lena Orobei <[email protected]>
|
@lenaorobei OK, cool. That approach works for me. |
lenaorobei
approved these changes
Aug 16, 2019
lenaorobei
added a commit
to konarshankar07/magento-coding-standard
that referenced
this pull request
Aug 16, 2019
- fixed readme
hostep
added a commit
to baldwin-agency/magento2-module-url-data-integrity-checker
that referenced
this pull request
Aug 18, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 25, 2021
* AC-1060: Move relevant sniffs from PHPCompatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
composer install --no-devthe bash command[ $COMPOSER_DEV_MODE -eq 1]will cause an exit code of 1. Build environments such as bitbucket piplines will often halt the build when encountering a none zero exit code. To resolve this, we force the exit code to be 0 with some boolean logic.