AC-1549: Create codes for each type of returned error / warning #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loginesta
previously approved these changes
Oct 26, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
danidelcar
previously approved these changes
Oct 26, 2021
sivaschenko
requested changes
Oct 26, 2021
There was a problem hiding this comment.
Thanks for PR @svera . Please see my comments.
Can you please also review all other error/warning codes in the recently introduced sniffs and ensure they are following the same style: CamelCaseStartingFromCapitalLetter
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
Co-authored-by: Sergii Ivashchenko <[email protected]>
Co-authored-by: Sergii Ivashchenko <[email protected]>
Co-authored-by: Sergii Ivashchenko <[email protected]>
Co-authored-by: Sergii Ivashchenko <[email protected]>
Co-authored-by: Sergii Ivashchenko <[email protected]>
sivaschenko
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sniffs in magento-static-tests return more than one error / warning with the same error code. These errors should return its own error codes instead.
Sniff included in this PR: