#29: [New Rule] Exceptions must not be handled in the same function

[larsroettig]

see #29

[lenaorobei]

Could you please move sniff under Exceptions folder. It looks like more appropriate place for this check.

[larsroettig]

@lenaorobei fixes for review done

[danmooney2]

Exceptions that throw with only one catch block pass.
This one fails correctly:

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

namespace Magento;

/**
 * Doer
 */
class Doer
{
    /**
     * Do Something
     */
    public function doSomething()
    {
        try {
            $result = 2;
        } catch (\DummyException $e) {
            throw $e;
        } catch (\NewException $e) {
            throw $e;
        }

        return $result;
    }
}

But this passes:

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

namespace Magento;

/**
 * Doer
 */
class Doer
{
    /**
     * Do Something
     */
    public function doSomething()
    {
        try {
            $result = 2;
        } catch (\DummyException $e) {
            throw $e;
        }

        return $result;
    }
}

Am I missing something?

[larsroettig]

@danmooney2 Can you open a bug report than I take a look.
king regards,

Lars

[danmooney2]

@larsroettig #93

[larsroettig]

Thanks, I will take a look this week