Skip to content

Pre-release fixes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Pre-release fixes #71

merged 4 commits into from
Mar 22, 2019

Conversation

lenaorobei
Copy link
Contributor

@lenaorobei lenaorobei commented Mar 21, 2019

  • removed DateTime sniff because the check is not sufficient enough. See [New Rule] Improper Date/Time handling #70 for details;
  • added exclude-pattern for RawQuery and EmptyCheck sniffs;
  • removed CyclomaticComplexity, because it's covered by PHPMD.

@lenaorobei lenaorobei requested a review from paliarush March 21, 2019 17:15
@larsroettig larsroettig self-requested a review March 21, 2019 19:03
larsroettig
larsroettig previously approved these changes Mar 21, 2019
larsroettig
larsroettig previously approved these changes Mar 21, 2019
@lenaorobei lenaorobei changed the title Removed DateTime sniff Pre-release fixes Mar 21, 2019
@lenaorobei lenaorobei merged commit a8004cc into develop Mar 22, 2019
@lenaorobei lenaorobei deleted the remove-date-time-sniff branch March 22, 2019 18:13
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 23, 2021
…-coding-standard-273

[Imported] AC-662: Create phpcs static check for AutogeneratedClassNotInConstructorTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants