MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found #7780

Oleksii Korshenko · web-flow · commit 268b21729e6f · 2017-06-12T13:34:47.000-05:00
diff --git a/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php b/setup/src/Magento/Setup/Module/Di/Compiler/Log/Log.php
@@ -80,11 +80,17 @@ public function add($type, $key, $message = '')
      * Write entries
      *
      * @return void
+     * @throws \Magento\Framework\Validator\Exception
      */
     public function report()
     {
         $this->_successWriter->write($this->_successEntries);
         $this->_errorWriter->write($this->_errorEntries);
+        //do not take into account empty items since they are initialized in constructor.
+        $errors = array_filter($this->_errorEntries);
+        if (count($errors) > 0) {
+            throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -80,11 +80,17 @@ public function add($type, $key, $message = '')`
`80`	`80`	`* Write entries`
`81`	`81`	`*`
`82`	`82`	`* @return void`
	`83`	`+ * @throws \Magento\Framework\Validator\Exception`
`83`	`84`	`*/`
`84`	`85`	`public function report()`
`85`	`86`	`{`
`86`	`87`	`$this->_successWriter->write($this->_successEntries);`
`87`	`88`	`$this->_errorWriter->write($this->_errorEntries);`
	`89`	`+ //do not take into account empty items since they are initialized in constructor.`
	`90`	`+ $errors = array_filter($this->_errorEntries);`
	`91`	`+ if (count($errors) > 0) {`
	`92`	`+ throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));`
	`93`	`+ }`
`88`	`94`	`}`
`89`	`95`
`90`	`96`	`/**`