Merge pull request #757 from magento-falcons/MAGETWO-63295

Bug:
- MAGETWO-63295 Installation fails because 'generated' directory is not writable

Author: VladimirZaets

.gitignore

@@ -51,3 +51,5 @@ atlassian*
 !/var/.htaccess
 /vendor/*
 !/vendor/.htaccess
+/generated/*
+!/generated/.htaccess

lib/internal/Magento/Framework/App/Filesystem/DirectoryList.php

@@ -109,6 +109,11 @@ class DirectoryList extends \Magento\Framework\Filesystem\DirectoryList
 
     const TEMPLATE_MINIFICATION_DIR = 'html';
 
+    /**
+     * Directory name for generated data.
+     */
+    const GENERATED = 'generated';
+
     /**
      * {@inheritdoc}
      */
@@ -135,6 +140,7 @@ public static function getDefaultConfig()
             self::TEMPLATE_MINIFICATION_DIR => [parent::PATH => 'var/view_preprocessed/html'],
             self::SETUP => [parent::PATH => 'setup/src'],
             self::COMPOSER_HOME => [parent::PATH => 'var/composer_home'],
+            self::GENERATED => [parent::PATH => 'generated'],
         ];
         return parent::getDefaultConfig() + $result;
     }

lib/internal/Magento/Framework/App/Test/Unit/Filesystem/DirectoryListTest.php

@@ -38,4 +38,31 @@ public function testUnknownDirectory()
     {
         new DirectoryList('/root/dir', ['test' => [DirectoryList::PATH => '/baz']]);
     }
+
+    public function testGetDefaultConfig()
+    {
+        $defaultConfig = DirectoryList::getDefaultConfig();
+
+        $this->assertArrayHasKey(DirectoryList::GENERATED, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::DI, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::GENERATION, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::ROOT, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::APP, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::CONFIG, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::LIB_INTERNAL, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::VAR_DIR, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::CACHE, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::LOG, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::SESSION, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::MEDIA, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::STATIC_VIEW, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::PUB, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::LIB_WEB, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::TMP, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::UPLOAD, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::TEMPLATE_MINIFICATION_DIR, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::TMP_MATERIALIZATION_DIR, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::SETUP, $defaultConfig);
+        $this->assertArrayHasKey(DirectoryList::COMPOSER_HOME, $defaultConfig);
+    }
 }

lib/internal/Magento/Framework/Setup/FilePermissions.php

@@ -82,6 +82,7 @@ public function getInstallationWritableDirectories()
                 DirectoryList::VAR_DIR,
                 DirectoryList::MEDIA,
                 DirectoryList::STATIC_VIEW,
+                DirectoryList::GENERATED,
             ];
             foreach ($data as $code) {
                 $this->installationWritableDirectories[$code] = $this->directoryList->getPath($code);

lib/internal/Magento/Framework/Setup/Test/Unit/FilePermissionsTest.php

@@ -68,6 +68,7 @@ public function testGetInstallationWritableDirectories()
             BP . '/var',
             BP . '/pub/media',
             BP . '/pub/static',
+            BP . '/generated'
         ];
 
         $this->assertEquals($expected, $this->filePermissions->getInstallationWritableDirectories());
@@ -157,6 +158,7 @@ public function testGetMissingWritableDirectoriesAndPathsForInstallation()
             BP . '/var',
             BP . '/pub/media',
             BP . '/pub/static',
+            BP . '/generated'
         ];
 
         $this->assertEquals(
@@ -231,6 +233,11 @@ public function setUpDirectoryListInstallation()
             ->method('getPath')
             ->with(DirectoryList::STATIC_VIEW)
             ->will($this->returnValue(BP . '/pub/static'));
+        $this->directoryListMock
+            ->expects($this->at(4))
+            ->method('getPath')
+            ->with(DirectoryList::GENERATED)
+            ->will($this->returnValue(BP . '/generated'));
     }
 
     public function setUpDirectoryWriteInstallation()