Skip to content

Setup process data #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tzyganu opened this issue Nov 21, 2014 · 7 comments
Closed

Setup process data #757

tzyganu opened this issue Nov 21, 2014 · 7 comments
Assignees
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Nov 21, 2014

I see that the data entered in the setup process, db credentials, base url, locale and others are saved in the localStorage.
This includes the admin email and password that are saved in clear text.
I don't think that saving the password is a good idea.

@Vinai
Copy link
Contributor

Vinai commented Nov 21, 2014

👍

@antonmakarenko
Copy link

The workflow of installation wizard is designed in a way that all data is collected first, then submitted as one "transaction" at the last step. This allows performing installation reliably in 1 process without any footprint remaining. So we need to carry this data over somehow through all the workflow steps.

What if we clear the localStorage at the end of installation? Is it good enough?

@tzyganu
Copy link
Contributor Author

tzyganu commented Nov 21, 2014

Clearing the local storage is better than nothing

@antonmakarenko
Copy link

Ok, for now we'll clear the local storage in the beginning and at the end of wizard workflow. This fix will be available in one of the next dev releases.

@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-31608

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PROD and removed TECH labels Feb 20, 2015
@tzyganu
Copy link
Contributor Author

tzyganu commented Feb 25, 2015

@antonmakarenko this seams to be OK now. Do you plan any other changes regarding the local storage? If not you can close this issue?

@tanya-soroka
Copy link

Right now all data is saved on the localstorage of the browser memory during installation. After installation this data is cleared.

I am going to close this ticket. Please feel free to reopen.

mmansoor-magento pushed a commit that referenced this issue Jan 23, 2017
Bug:
- MAGETWO-63295 Installation fails because 'generated' directory is not writable
magento-engcom-team added a commit that referenced this issue Jul 24, 2019
 - Merge Pull Request magento/graphql-ce#757 from pmclain/graphql-ce:issue/751
 - Merged commits:
   1. 7f9ccaa
   2. 0d0aca1
   3. d4a859d
   4. 887f33b
   5. c221853
   6. bad6669
magento-engcom-team added a commit that referenced this issue Jul 30, 2019
 - Merge Pull Request magento/graphql-ce#757 from pmclain/graphql-ce:issue/751
 - Merged commits:
   1. 69aab33
magento-engcom-team pushed a commit that referenced this issue Jan 14, 2020
Added test case ids and updated action group names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants