-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Setup process data #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 |
The workflow of installation wizard is designed in a way that all data is collected first, then submitted as one "transaction" at the last step. This allows performing installation reliably in 1 process without any footprint remaining. So we need to carry this data over somehow through all the workflow steps. What if we clear the localStorage at the end of installation? Is it good enough? |
Clearing the local storage is better than nothing |
Ok, for now we'll clear the local storage in the beginning and at the end of wizard workflow. This fix will be available in one of the next dev releases. |
Internal ticket: MAGETWO-31608 |
@antonmakarenko this seams to be OK now. Do you plan any other changes regarding the local storage? If not you can close this issue? |
Right now all data is saved on the localstorage of the browser memory during installation. After installation this data is cleared. I am going to close this ticket. Please feel free to reopen. |
Bug: - MAGETWO-63295 Installation fails because 'generated' directory is not writable
- Merge Pull Request magento/graphql-ce#757 from pmclain/graphql-ce:issue/751 - Merged commits: 1. 69aab33
Added test case ids and updated action group names.
I see that the data entered in the setup process, db credentials, base url, locale and others are saved in the
localStorage
.This includes the admin email and password that are saved in clear text.
I don't think that saving the password is a good idea.
The text was updated successfully, but these errors were encountered: