MAGETWO-62914: [Backport] - [Github] Directive values are not quote-escaped #3860 - for 2.1

DianaRusin · DianaRusin · commit e9ff1c24fd1b · 2017-05-04T16:03:33.000+03:00
diff --git a/app/code/Magento/Widget/Model/Widget.php b/app/code/Magento/Widget/Model/Widget.php
@@ -313,7 +313,7 @@ public function getWidgetDeclaration($type, $params = [], $asIs = true)
                     $value = $parameters[$name]->getValue();
                 }
             }
-            if ($value) {
+            if (isset($value)) {
                 $directive .= sprintf(' %s="%s"', $name, $this->escaper->escapeQuote($value));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ public function getWidgetDeclaration($type, $params = [], $asIs = true)`
`313`	`313`	`$value = $parameters[$name]->getValue();`
`314`	`314`	`}`
`315`	`315`	`}`
`316`		`- if ($value) {`
	`316`	`+ if (isset($value)) {`
`317`	`317`	`$directive .= sprintf(' %s="%s"', $name, $this->escaper->escapeQuote($value));`
`318`	`318`	`}`
`319`	`319`	`}`