-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Directive values are not quote-escaped #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
reproduced. Internal issue MAGETWO-54243 |
Does this fix product attributes also? If i insert an image (in product's description) through the UI in backend i see the "right" media directive syntax, after saving there is just a mess left... |
@veloraven @magento-team What version of Magento will this fix be included in? |
@veloraven Also need some kind of escape when value is cms directive. Need something at the: lib/web/mage/adminhtml/wysiwyg/tiny_mce/setup.js for decodeDirectives & necodeDirectives functions |
…o#3860 (cherry picked from commit 3ff19bf) MAGETWO-54243: [Github] Directive values are not quote-escaped magento#3860 (cherry picked from commit c2fd296) MAGETWO-54243: [Github] Directive values are not quote-escaped magento#3860 (cherry picked from commit 0859c7d)
Internal ticket to track issue progress: MAGETWO-70436 |
MAGETWO-98574: Stabilization of copy paste detector test
This is still the case: http://stackoverflow.com/questions/23925826/magento-widgets-truncate-fields-containing-quotes
I can imagine why this is happening.
The fix is up to you. There are several ways to tackle this.
Steps to reproduce
There is no "escape"!
Expected result
{{... my_text_value="There is no "escape"!"}}
<-- this looks wrong, ofc, but it's just to show you what I mean.Actual result
{{... my_text_value="There is no "}}
The text was updated successfully, but these errors were encountered: