Skip to content

Commit f54e887

Browse files
Merge pull request #1627 from magento-engcom/develop-prs
[EngCom] Public Pull Requests - develop - MAGETWO-82721 Fix datetime type product that show current date when is empty in grids #11636 - MAGETWO-82653 GitHub 11380 #11683 - MAGETWO-82558 FIX show visual swatches in admin - product attribute #11661
2 parents fef1485 + d7e619b commit f54e887

File tree

4 files changed

+11
-4
lines changed
  • app/code/Magento
    • Sales/view/adminhtml/templates/order/create/billing/method
    • Swatches/view/adminhtml/web/css
    • Ui/view/base/web/js/grid/columns
  • dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method

4 files changed

+11
-4
lines changed

app/code/Magento/Sales/view/adminhtml/templates/order/create/billing/method/form.phtml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@
5555
'Magento_Sales/order/create/form'
5656
], function(mage) {
5757
mage.apply();
58-
<?php if ($_methodsCount != 1) : ?>
5958
order.setPaymentMethod('<?= $block->escapeHtml($block->getSelectedMethodCode()); ?>');
60-
<?php endif; ?>
6159
});
6260
</script>
6361
<?php else : ?>

app/code/Magento/Swatches/view/adminhtml/web/css/swatches.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
* See COPYING.txt for license details.
44
*/
55

6+
#swatch-visual-options-panel{
7+
overflow: visible;
8+
}
9+
610
.swatch_sub-menu_container {
711
position: absolute;
812
z-index: 9999;

app/code/Magento/Ui/view/base/web/js/grid/columns/date.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ define([
3939
getLabel: function (value, format) {
4040
var date = moment(this._super());
4141

42-
date = date.isValid() ?
42+
date = date.isValid() && value[this.index] ?
4343
date.format(format || this.dateFormat) :
4444
'';
4545

dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method/FormTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ public function testContentUpdated()
4545
$block = $this->layout->createBlock(Form::class, 'order_billing_method');
4646
$block->setTemplate('Magento_Sales::order/create/billing/method/form.phtml');
4747

48-
$this->assertContains('mage.apply()', $block->toHtml());
48+
$html = $block->toHtml();
49+
$this->assertContains('mage.apply()', $html);
50+
$this->assertContains(
51+
"order.setPaymentMethod('" . $block->escapeHtml($block->getSelectedMethodCode()) . "')",
52+
$html
53+
);
4954
}
5055
}

0 commit comments

Comments
 (0)