Skip to content

Fix datetime type product that show current date when is empty in grids #11636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Oct 22, 2017

Description

In the product grid, when a date attribute is listed and the value was empty, the current date was displayed. This was very confusing because I did not know if the value was assigned or not. Now you can see empty cells when is unassigned.

Fixed Issues (if relevant)

datetime type product attribute showing current date #9869

Manual testing scenarios

  1. Create a date type product attribute
  2. assign that product to the required attribute set
  3. you can edit the attribute value in the product edit.
  4. create a new product and simply not assign any value to this attribute.
  5. save product
  6. Now you dont see the current date if is unset.

NOW:
screen shot 2017-10-24 at 08 55 38

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 22, 2017

CLA assistant check
All committers have signed the CLA.

@enriquei4
Copy link
Contributor Author

@miguelbalparda Could I backport this to 2.2 and 2.1?

@miguelbalparda
Copy link
Contributor

Yes please @enriquei4!

@magento-team magento-team merged commit 3564aba into magento:2.3-develop Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
[EngCom] Public Pull Requests - develop
 - MAGETWO-82721 Fix datetime type product that show current date when is empty in grids #11636
 - MAGETWO-82653 GitHub 11380 #11683
 - MAGETWO-82558 FIX show visual swatches in admin - product attribute #11661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants