Skip to content

Refactoring: Adding items to the Sitemap #10045

Closed
@avoelkl

Description

@avoelkl

PR #9970 was already an improvement to the sitemap for easier adding of additional items.

@antonkril suggested to refactor the improved behaviour even more:

Expected result

Better approach in this case would be to introduce the reversed extension point: some kind of $ItemResolver dependency that would be called by sitemap (with sitemap id argument) to load custom sitemap items.

This dependency could be implemented as a composite, or just pluginized by third-party developers to add new items to the custom list.

Metadata

Metadata

Labels

Fixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseup for grabs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions