Magento BundleProduct Error

[riyuk]

Preconditions

1. Magento 2.1.7
2. PHP 7

Steps to reproduce

1. Setup a BundleProduct
2. Assign ~35 Options with about 45 Products for each Option
3. Close the Product
4. Create another Attribute-Set with more Custom Options
5. Open up the Product and try to assign it to the new Attribute-Set and press save

Expected result

1. Save Product as Expected

Actual result

1. Warning: Illegal string offset 'is_delete' in /vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php on line 197
2. Notice: Undefined index: delete in /vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php on line 130
3. Warning: Illegal string offset 'is_delete' in /vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php on line 200

I fixed this on Core with:

if( !isset( $customOptions[$key] ) || !is_array( $customOptions[$key] ) ) {
    $customOptions[$key] = [];
}

right before:

# Line 197
$customOptions[$key]['is_delete'] = 1;

---

if (isset($optionData['delete']) && (bool)$optionData['delete']) {

On Line 130:

# Line 130 before
if ((bool)$optionData['delete']) {

---

if (isset($customOptionData['is_delete']) && (bool)$customOptionData['is_delete']) {

On Line 200:

# Line 200 before
if ((bool)$customOptionData['is_delete']) {

It would be great, if magento2 does some validation on arrays before trying to access them.
There were a lot of errors like this before, which can easily prevented by doing some validation first...

[orlangur]

There were a lot of errors like this before, which can easily prevented by doing some validation first...

Not really, it would bloat the code and does not affect shop workability anyway.

Assign ~35 Options with about 45 Products for each Option

Does not look like an isolated test case to me. Did you find the reason why delete and is_delete indexes are absent?

[riyuk]

I really don't know. We've not installed any extensions on magento.
This error "just occured". I can't tell you why since I don't know what the Support/Plugin does on Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php.

What I just discovered is that we created a ticket a long time ago for (maybe) the exact same reason.

• Update Bundle Product without changes in bundle items  #6916
  It was "acknowledged" then, but it seems it was never really fixed.

[robertkent]

I can confirm this is a problem in 2.1.8 - it essentially happens if the Bundle Items goes onto different pages using it's own pagination in the edit product page. Seems to be after 39 options if that helps.

[magento-engcom-team]

@riyuk thank you for your report.
We were not able to reproduce this issue by following the steps you provided.
Please provide more details. And can You please clarify step 4? What do You mean by "Create another Attribute-Set with more Custom Options"?

[magento-engcom-team]

@riyuk, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.

[allisonlawrencels]

I reported this issue to the Magento team as well, for 2.2.1 and I am still seeing it in 2.2.3, but they were not able to reproduce. Has anyone had any luck with this?

Magento team, what other information would you suggest we provide to help you reproduce the bug?

[riyuk]

The error still exists in Magento 2.3.0.
We got a Bundleproduct with 23 Options. These Options are Select Fields with up to 40 different virtual Products.

[orlangur]

This could be related to environment configuration, for example https://www.php.net/manual/en/info.configuration.php#ini.max-input-vars