Skip to content

Update Bundle Product without changes in bundle items #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
magecodenet opened this issue Oct 7, 2016 · 11 comments
Closed

Update Bundle Product without changes in bundle items #6916

magecodenet opened this issue Oct 7, 2016 · 11 comments
Assignees
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@magecodenet
Copy link

magecodenet commented Oct 7, 2016

Preconditions

  1. Latest Magento 2.1.1 from release archive

Steps to reproduce

  1. Admin -> Catalog -> Products
  2. Edit Bundle product, nothing change, just save it

If you just update (not new) bundle product and edit any Bundle Items Saves works
I added new category and image, saves not works. Actually saves doesn't work for me even without any changes.

Update: i have more then 20 items, and save works only if i go to page 2 and wait until it loaded, then saves works correct.

Actual result

Notice: Undefined index: delete in .../vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php on line 130

@riyuk
Copy link

riyuk commented Oct 7, 2016

Replacing in File /vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php:
if ((bool)$optionData['delete']) {
&
if ((bool)$linkData['delete']) {

With:
if (isset($optionData['delete']) && (bool)$optionData['delete']) {
&
if (isset($linkData['delete']) && (bool)$linkData['delete']) {

does fix the Problem for me.
Probably also the solution for #6046.

@magecodenet
Copy link
Author

yeah, tx, just i want to get this working in next release :)

@TommyKolkman
Copy link

@riyuk Thanks for the quick fix, works for me too. But come on Magento, this seriously can't be happening. We've got quite some websites depending on this stuff...

@TommyKolkman
Copy link

@riyuk When I apply your fix, by the way, connections from catalog_product_bundle_option_value seem to disappear. Had this problem?

@quynhvv
Copy link

quynhvv commented Nov 3, 2016

Hi guys,

Notice: Undefined index: delete in .../vendor/magento/module-bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php on line 130

The root issue because the attribute sets of your bundle products was missing the Attribute group named
Bundle Items
So to solve this issue, for each the Attribute Set of your bundle products let's open it and add more the Attribute Group named Bundle Items and move the Attribute code named shipment_type to the Attribute Group you have just added. See more here: http://i.prntscr.com/1e45d623dafc4a8d97297ccf3b4eba6e.png

Let's do it to solve the issue!
Regards,
quynhvv

@IlnitskiyArtem
Copy link

@magecodenet, thanks for reporting this issue
Unfortunately I could not reproduce this issue. May you please advise if this problem is still relevant for latest release Magento 2?

@magekey
Copy link
Contributor

magekey commented Jun 23, 2017

@IlnitskiyArtem
yes it still there.

Release 2.1.7

Steps to reproduce:

  1. Edit sample product "Sprite Yoga Companion Kit"
  2. by default this product has 4 options in bundle items. You need to add more so in total you have at least 21 options. And now we got Bundle Items pager.
  3. Save product with all options and reload page.
  4. Click save without any changes. you should see error.
  5. If you move to the second page of bundle items and click save everything works correct.
    Looks like system think we trying to remove invisible items.

@IlnitskiyArtem
Copy link

@magekey, Thanks for the additional information!
We've created internal ticket MAGETWO-70162 to address this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 23, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@magecodenet, thank you for your report.
We've created internal ticket(s) MAGETWO-70162 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@magento-team
Copy link
Contributor

Hi @magecodenet. Thank you for your report.
The issue has been fixed in #12734 by @dzianis-yurevich in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 28, 2017
magento-team pushed a commit that referenced this issue Dec 28, 2017
…changes #12734

 - Merge Pull Request #12734 from dzianis-yurevich/magento2:issue/6916
 - Merged commits:
   1. e6a7a4e
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @magecodenet. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1359 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests