ReindexAll -> getState() is not correct if the Indexer broke with PHP fatal error

[larsroettig]

If some fatal PHP error happens in the indexing process. The status is not correct reset
to StateInterface::STATUS_INVALID

Preconditions

• Magento 2.3.0-dev

Steps to reproduce

• Implement Indexer -> fatal error in executeFull()
• executebin/magento indexer:reindex **your_index_name**

Expected result

• Status is not working in Magento\Indexer\Model\Indexer line 404

Actual result

• Status is working in Magento\Indexer\Model\Indexer line 404

[magento-engcom-team]

Hi @larsroettig
Please try to describe the issue in-depth. Current description is ambiguous.
Thank you!

[larsroettig]

Hi, @magento-engcom-team, I update the descriptions.

I recommend changing reindexAll to :

    /**
     * Regenerate full index
     *
     * @return void
     * @throws \Exception
     */
    public function reindexAll()
    {
        if ($this->getState()->getStatus() != StateInterface::STATUS_WORKING) {
            $state = $this->getState();
            $state->setStatus(StateInterface::STATUS_WORKING);
            $state->save();
            if ($this->getView()->isEnabled()) {
                $this->getView()->suspend();
            }
            try {
                $this->getActionInstance()->executeFull();
                $state->setStatus(StateInterface::STATUS_VALID);
                $state->save();
                $this->getView()->resume();
            } catch (\Exception $exception) {
                $state->setStatus(StateInterface::STATUS_INVALID);
                $state->save();
                $this->getView()->resume();
                throw $exception;
            } catch (\Error $error) {
                $state->setStatus(StateInterface::STATUS_INVALID);
                $state->save();
                $this->getView()->resume();
                throw $error;
            }
        }
    }