Skip to content

Substitution payment method - Incorrect message #12209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ihor-sviziev opened this issue Nov 13, 2017 · 3 comments
Closed

Substitution payment method - Incorrect message #12209

ihor-sviziev opened this issue Nov 13, 2017 · 3 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 13, 2017 •
edited
Loading

Preconditions

  1. Magento 2.1.9 (same should be in 2.2-develop and 2.3-develop)
  2. DB migrated from M1, payment method wasn't migrated, so it's not available

Steps to reproduce

  1. Go to Admin panel and look at existing order
  2. View "Payment & Shipping Method" section

Expected result

We should have message "<payment_method_name> is not available. You still can process offline actions." OR we should have message "Payment method is not available. You still can process offline actions.

Actual result

We have message "is not available. You still can process offline actions."
image

Tech note

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml#L13

  1. payment method title isn't printed
  2. There is no check if title is not empty
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 13, 2017
@ihor-sviziev ihor-sviziev changed the title Substitution payment method - Substitution payment method - Incorrect message Nov 13, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 14, 2017
@magento-engcom-team
Copy link
Contributor

@ihor-sviziev, thank you for your report.
We've created internal ticket(s) MAGETWO-83822 to track progress on the issue.

zamoroka pushed a commit to zamoroka/magento2 that referenced this issue Dec 15, 2017
@AndrewMun
magento#12209: Substitution payment method - Incorrect message
30b8293 
- fixed message showing if payment method is not available
@zamoroka zamoroka mentioned this issue Dec 15, 2017
Merged
4 tasks
@magento-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #12731 by @zamoroka in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@okorshenko
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1325 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@magento-team @ihor-sviziev @okorshenko @magento-engcom-team