Skip to content

New Cart Rule : Small styles issue because of styles-old.css #12231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Triloworld opened this issue Nov 14, 2017 · 2 comments
Closed

New Cart Rule : Small styles issue because of styles-old.css #12231

Triloworld opened this issue Nov 14, 2017 · 2 comments
Assignees
@serhii-balko
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Triloworld
Copy link

Text is cut because of left margin.

Preconditions

  1. Working Magento 2
  2. Compiled default styled from backend

Steps to reproduce

  1. Have configured one website with name SHOP.NAME
  2. Go to Marketing -> Cart Rules -> New Cart Rule
  3. When page load go immediately (no input provided) to section "Store View Specific Labels" and unfold
  4. Check if labels are on left and they are cut. Even more, they duplicate.

Expected result

  1. In one line with others item. After all, not cut.

Actual result

  1. Screen provided

zrzut ekranu 2017-11-14 o 09 44 16

In right section you can see "margin-left: 0". Comment to see how it is better. I think there is even duplicate show of name but more obvious is text being cut.
This is done by "styles-old.css".
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 14, 2017
@Triloworld Triloworld changed the title Small styles issue on backend because of styles-old.css New Cart Rule : Small styles issue because of styles-old.css Nov 14, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 14, 2017
@magento-engcom-team
Copy link
Contributor

@Triloworld, thank you for your report.
We've created internal ticket(s) MAGETWO-83819 to track progress on the issue.

@serhii-balko serhii-balko self-assigned this Jan 3, 2018
@magento-team
Copy link
Contributor

Hi @Triloworld. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1146 by @serhii-balko in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 22, 2018
magento-team pushed a commit that referenced this issue Jan 22, 2018
@serhii-balko
#12231: [GitHub] New Cart Rule : Small styles issue because of styles…
cdff30d 
…-old.css
magento-team pushed a commit that referenced this issue Jan 22, 2018
@ishakhsuvarov
MAGETWO-86896: #12231: [GitHub] New Cart Rule : Small styles issue be…
d646878 
…cause of styles… #1146

 - Merge Pull Request magento-engcom/magento2ce#1146 from serhii-balko/magento2:gthub-12231
 - Merged commits:
   1. cdff30d
magento-team pushed a commit that referenced this issue Jan 22, 2018
@ishakhsuvarov
MAGETWO-86896: #12231: [GitHub] New Cart Rule : Small styles issue be…
f00217a 
…cause of styles… #1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhii-balko serhii-balko

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@magento-team @Triloworld @okorshenko @serhii-balko @magento-engcom-team