Skip to content

Model hasDataChanges always true #12374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Detzler opened this issue Nov 21, 2017 · 6 comments
Closed

Model hasDataChanges always true #12374

Detzler opened this issue Nov 21, 2017 · 6 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Detzler
Copy link

Detzler commented Nov 21, 2017

Preconditions

  1. PHP7.1
  2. Magento2.2

Steps to reproduce

  1. Execute:
...
$collection = $collectionFactory->create();                              
$collection->addAttributeToSelect('*');
$category = $collection->getFirstItem();
var_dump($category->hasDataChanges());
$category->save();

Expected result

  1. hasDataChanges returns false because no data has been changed

Actual result

  1. hasDataChanges returns true
  2. Performance impact on $category->save()
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 21, 2017
@magento-engcom-team
Copy link
Contributor

@Detzler, thank you for your report.
We've created internal ticket(s) MAGETWO-84213 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 21, 2017
@virtual97
Copy link

#mageconf

@magento-engcom-team
Copy link
Contributor

@virtual97 thank you for joining. Please accept team invitation here and self-assign the issue.

virtual97 added a commit to virtual97/magento2-1 that referenced this issue Dec 15, 2017
@virtual97 virtual97 self-assigned this Dec 15, 2017
@virtual97 virtual97 mentioned this issue Dec 15, 2017
4 tasks
@magento-team
Copy link
Contributor

Hi @Detzler. Thank you for your report.
The issue has been fixed in #12736 by @virtual97 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 28, 2017
@magento-engcom-team
Copy link
Contributor

Hi @Detzler. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1359 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 8, 2018
@mhafizumer
Copy link

Still issue, $product->hasDataChanges() return me true whenever I edit or not edit any attribute data.
I am using magento 2.4.1 CE

@virtual97 virtual97 removed their assignment Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants