Skip to content

Multiselect Attribute is not saved for a product in the admin panel when it has a related product using another attribute set #12699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmisyura opened this issue Dec 14, 2017 · 5 comments
Closed

Multiselect Attribute is not saved for a product in the admin panel when it has a related product using another attribute set #12699

bmisyura opened this issue Dec 14, 2017 · 5 comments
Assignees
@andrii-dymov
Labels
bug report Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@bmisyura
Copy link

bmisyura commented Dec 14, 2017 •
edited
Loading

Preconditions

  1. Install Magento from 2.2.-develop branch

Steps to reproduce

  1. Create 2 attribute sets from the Default one.
  2. Create a multi-select attribute and assign it to set Can you commit to repository a folder dev/tests/static ? #1.
  3. Create a product 1 with attribute set BUG FIX - Uncaught exception when accessing admin with none existent use... #2.
  4. Create a product 2 with attribute set Can you commit to repository a folder dev/tests/static ? #1 and set a product 1 as it's related product.
  5. Save product 2 without populating the multi-select.
  6. Edit the product 2, populate multi-select and click save.
  7. Notice the selected option is not saved

Expected result

Multiselect Attribute should be saved for a product in the admin panel when it has a related product using another attribute set.

Actual result

Multiselect Attribute is not saved for a product in the admin panel when it has a related product using another attribute set
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Dec 14, 2017
@alena-marchenko alena-marchenko added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 14, 2017
@andrii-dymov
Copy link

#mageconf

@magento-engcom-team
Copy link
Contributor

@awarche thank you for joining. Please accept team invitation here and self-assign the issue.

@andrii-dymov andrii-dymov self-assigned this Dec 15, 2017
@andrii-dymov
Copy link

The issue is in Eav AbstractEntity which stores linked product's attribute codes after we load linked products.
These codes do not include our multiselect attribute, therefore it's skipped in beforeSave method, it's array value is not converted to a string literal and UpdateHandler silently skips it.
Already fixed in 2.1 branch, working on backport.

@andrii-dymov andrii-dymov added backport Fixed in 2.1.x The issue has been fixed in 2.1 release line labels Dec 15, 2017
andrii-dymov pushed a commit to andrii-dymov/magento2 that referenced this issue Dec 15, 2017
magento#12699: fixed attribute loading for different entities in Abst…
39098d8 
…ractEntity
andrii-dymov pushed a commit to andrii-dymov/magento2 that referenced this issue Dec 19, 2017
magento#12699: new attribute should be private
49ae5fa
@ishakhsuvarov
Copy link
Contributor

Closing, as the issue seems to be fixed in 2.2-develop with the PR #12767
Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @bmisyura. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1362 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-dymov andrii-dymov

Labels
bug report Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@andrii-dymov @ishakhsuvarov @okorshenko @alena-marchenko @magento-engcom-team @bmisyura