Could you add TYPE_VARCHAR

[SKovbel]

Could you add new type
\Magento\Framework\DB\Ddl\Table::TYPE_VARCHAR

[orlangur]

TYPE_TEXT is used for this:
https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php#L1685
https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php#L2277

[SKovbel]

So is varchar type deprecated in Magento2?
Or what the reason why i must use text instead of varchar

[nevvermind]

@Mackovey - have you clicked the links? varchar will be used if the specified col length is <= 255.

[orlangur]

So is varchar type deprecated in Magento2?

No, just one TYPE_TEXT constant is used to represent all following types:

            case 'tinytext':
            case 'char':
            case 'varchar':
            case 'text':
            case 'mediumtext':
            case 'longtext':
                return Table::TYPE_TEXT;

and the most suitable type of the DB engine will be used automatically.

[SKovbel]

No, just one TYPE_TEXT constant is used to represent all following types:

ok, understood, thanx

[vpelipenko]

@Mackovey, can we close this issue?

[SKovbel]

You can.
But i didn't receive answer for my question.
What i must to do if i want to use VARCHAR or what the idea of using TEXT instead of VARCHAR.
Or just forget about class \Magento\Framework\DB\Ddl\Table as it doesn't provide all DDL instruction.

[orlangur]

Ok, now I understood you request.

https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php#L2277 seems to be from ages when VARCHAR could not be longer than 255 characters.

After reading this thread I'm not sure whether there is a practical reason to have VARCHAR column longer than 255 characters:

Both VARCHAR and BLOB/TEXT are stored inline with other columns if the value on a given row fits in the page size

Thoughts?

[akaplya]

The reason to keep varchar size less than 256 symbols -- give an ability to create index for single varchar field. http://dev.mysql.com/doc/refman/5.6/en/column-count-limit.html