Skip to content

Outdated package after upgrade sjparkinson/static-review is abandoned #14138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
woshka opened this issue Mar 16, 2018 · 3 comments
Closed

Outdated package after upgrade sjparkinson/static-review is abandoned #14138

woshka opened this issue Mar 16, 2018 · 3 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@woshka
Copy link

woshka commented Mar 16, 2018

outdated package after upgrade

Package sjparkinson/static-review is abandoned, you should avoid using it. Use phpro/grumphp instead.
Package fabpot/php-cs-fixer is abandoned, you should avoid using it. Use friendsofphp/php-cs-fixer instead.

Preconditions

  1. magento 2.12

Steps to reproduce

  1. upgrade using composer

Expected result

  1. no warning

Actual result

  1. [Screenshot, logs]
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 16, 2018
@ishakhsuvarov
Copy link
Contributor

Hi @woshka
Thank you for reporting.

There is a Pull Request which is going to fix it in 2.2.x soon: #14091

@orlangur orlangur mentioned this issue Mar 16, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @woshka. Thank you for your report.
The issue has been fixed in #14091 by @orlangur in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 24, 2018
@rostyslav-hymon rostyslav-hymon mentioned this issue Mar 26, 2018
Merged
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Mar 28, 2018

Hi @woshka. Thank you for your report.
The issue has been fixed in #14368 by @rostyslav-hymon in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ishakhsuvarov @woshka @sidolov @magento-engcom-team