[Forwardport] Remove sjparkinson/static-review and other obsolete tools #14368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14091
Description
Obsolete tools removed:
dev/tools/Magento/Tools/Layout
is a set of XSLT processors used within Magento 2 development prior to 2.0 GA. Can be useful only as a migration tool but those are consolidated in separate repo.dev/tools/Magento/Tools/StaticReview/pre-commit
pre-commit hook based onsjparkinson/static-review
implemented by me, never really liked it anyway as it processed files one-by-one, just tried to reuse some existing library instead of a custom bash scriptdev/tools/Magento/Tools/psr/phpcs_precommit_hook.sh
even older pre-commit hook, not worth fixing, better use PHPCS in IDE directly or viaphpro/grumphp
Fixed Issues (if relevant)
Only "Package sjparkinson/static-review is abandoned, you should avoid using it. Use phpro/grumphp instead." composer warning eliminated.
#14138
Manual testing scenarios
Nothing to test manually, it is enough to run automated tests.
Contribution checklist