Skip to content

[Forwardport] Remove sjparkinson/static-review and other obsolete tools #14368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rostyslav-hymon
Copy link
Contributor

Original Pull Request

#14091

Description

Obsolete tools removed:

  1. dev/tools/Magento/Tools/Layout is a set of XSLT processors used within Magento 2 development prior to 2.0 GA. Can be useful only as a migration tool but those are consolidated in separate repo.
  2. dev/tools/Magento/Tools/StaticReview/pre-commit pre-commit hook based on sjparkinson/static-review implemented by me, never really liked it anyway as it processed files one-by-one, just tried to reuse some existing library instead of a custom bash script
  3. dev/tools/Magento/Tools/psr/phpcs_precommit_hook.sh even older pre-commit hook, not worth fixing, better use PHPCS in IDE directly or via phpro/grumphp

Fixed Issues (if relevant)

Only "Package sjparkinson/static-review is abandoned, you should avoid using it. Use phpro/grumphp instead." composer warning eliminated.
#14138

Manual testing scenarios

Nothing to test manually, it is enough to run automated tests.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@kandy
Copy link
Contributor

kandy commented Mar 26, 2018

If you remove xslt files than maybe make sense to remove dev:xml:convert command and dependency on xslt extension from composer

@sidolov
Copy link
Contributor

sidolov commented Mar 26, 2018

@kandy, I think it may be separate PR for both versions, consider to make described changes and create PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants