Skip to content

Updating Customer through rest/all/V1/customers/:id resets group_id if group_id not passed in payload #14663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abancroft0 opened this issue Apr 12, 2018 · 9 comments
Labels
bug report Event: dmcdindia1 Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@abancroft0
Copy link

abancroft0 commented Apr 12, 2018

Preconditions

  1. Magento Version 2.2.3 using rest API
  2. Passing a JSON payload with minimum required data (email, first/last name, website_id, id)

Steps to reproduce

  1. Update any customer who's group_id isn't the first group_id in the source list
  2. Pass the customer payload with email, firstname, lastname, website_id, id

Expected result

  1. I expect that only the data passed in the payload would be modified
  2. Example: {"customer":{"email":"[email protected]","firstname":"magento","lastname":"user","website_id":1,"id":77486}} should leave the customer's full data structure unchanged.

Actual result

  1. If the above customer had a group_id of 5, and our full group_id consisted of [1,2,3,4,5], the customer's group_id after passing the above payload would be set to 1:

Before:
image

PUT:
image

Results:
image

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 12, 2018
@bydrei bydrei added bug report Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Apr 13, 2018
@bydrei
Copy link

bydrei commented Apr 13, 2018

@magento-engcom-team was able to replicate this. Ok if I self assign?

@magento-engcom-team
Copy link
Contributor

Hi @ferrazzuk
Sure, feel free to assign it to yourself if you feel like trying and fixing this

Thanks!

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 16, 2018
@bydrei bydrei self-assigned this Apr 16, 2018
@bydrei
Copy link

bydrei commented Apr 18, 2018

@magento-engcom-team pull request created.

@bydrei bydrei added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Apr 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @abancroft0. Thank you for your report.
The issue has been fixed in #14757 by @ferrazzuk in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label May 3, 2018
@sdzhepa sdzhepa assigned jignesh-baldha and unassigned bydrei Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@milindsingh milindsingh self-assigned this Feb 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @KishorkumarKar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@KishorkumarKar
Copy link

@magento-engcom-team I have fixed this issue. Creating the PR #22700.

@ghost ghost unassigned KishorkumarKar Jun 25, 2019
@ghost ghost assigned MaxRomanov4669 Dec 9, 2019
magento-engcom-team added a commit that referenced this issue Jan 3, 2020
…id resets group_id if group_id not passed in payload #25958

 - Merge Pull Request #25958 from MaxRomanov4669/magento2:14663-rest-api-customer-group-issue
 - Merged commits:
   1. 232e808
   2. 1a1ca42
   3. 3182759
   4. 3bce77f
magento-engcom-team pushed a commit that referenced this issue Jan 3, 2020
…id resets group_id if group_id not passed in payload #25958
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Sep 3, 2020
@ghost ghost removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 20, 2020
@sdzhepa sdzhepa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Nov 6, 2020
@magento-engcom-team magento-engcom-team added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 30, 2020
@stale
Copy link

stale bot commented Feb 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Event: dmcdindia1 Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

9 participants