Skip to content

Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php #15601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanjay-wagento opened this issue May 30, 2018 · 6 comments
Assignees
Labels
Component: Framework/Stdlib Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@sanjay-wagento
Copy link
Contributor

sanjay-wagento commented May 30, 2018

Preconditions

  1. Magento 2 code.

Steps to reproduce

  1. Observe \Magento\Framework\Stdlib\DateTime\TimezoneInterface::formatDateTime

Expected result

  1. The annotation for locale and timezone should be @param string|null $locale and @param string|null $timezone

Actual result

  1. The annotation for locale and timezone is @param null $locale and @param null $timezone
    /**
     * @param string|\DateTimeInterface $date
     * @param int $dateType
     * @param int $timeType
     * @param null $locale
     * @param null $timezone
     * @param string|null $pattern
     * @return string
     */
    public function formatDateTime(
        $date,
        $dateType = \IntlDateFormatter::SHORT,
        $timeType = \IntlDateFormatter::SHORT,
        $locale = null,
        $timezone = null,
        $pattern = null
    );
@magento-engcom-team
Copy link
Contributor

Hi @sanjay-wagento. Thank you for your report.
The issue has been fixed in #15667 by @vgelani in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sanjay-wagento. Thank you for your report.
The issue has been fixed in #15670 by @vgelani in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov
Copy link
Contributor

sidolov commented Jun 4, 2018

Hi @sanjay-wagento. Thank you for your report.
The issue has been fixed in #15669 by @vgelani in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 4, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 4, 2018

Hi @sanjay-wagento. Thank you for your report.
The issue has been fixed in #15668 by @vgelani in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@ghost ghost self-assigned this Sep 4, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Framework/Stdlib labels Sep 4, 2018
@ghost ghost removed their assignment Sep 4, 2018
@ghost
Copy link

ghost commented Sep 4, 2018

@sanjay-wagento, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 4, 2018
@ghost
Copy link

ghost commented Nov 30, 2018

Hi @sanjay-wagento , thank you for you report, this issue has already fixed in 2.3-develop branch, and available on 2.3.0 release.

@ghost ghost closed this as completed Nov 30, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Stdlib Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

3 participants