Skip to content

Remove / Edit Item in minicart does not work if span css is changed #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zaylril opened this issue Aug 18, 2015 · 3 comments
Closed

Remove / Edit Item in minicart does not work if span css is changed #1694

Zaylril opened this issue Aug 18, 2015 · 3 comments
Labels
bug report Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@Zaylril
Copy link

Zaylril commented Aug 18, 2015

Hey,

On our design we removed the span styles from the minicart "remove" and "edit" links which add the icon. This means that, because the span now has no styles (just shows the text) when you click the link the code in the JS to remove the item now finds the span not the a tag which contains the item id to remove and be sent with the post.

This took me a while to debug and I'm sure others may fall into the same trap. Perhaps something like this would be better.

        _removeItem: function(elem) {
            if(elem.prop('tagName') !== 'A') {
                elem = elem.parent('a');
            }
            var itemId = elem.data('cart-item');
            this._ajax(this.options.url.remove, {
                item_id: itemId
            }, elem, this._removeItemAfter);
        },

Thanks

@vpelipenko vpelipenko added the CS label Aug 19, 2015
@okorshenko
Copy link
Contributor

@Zaylril , thank you for reporting. Internal ticket MAGETWO-43229 is created to track this issue

@irenelagno
Copy link
Contributor

@Zaylril, internal ticket is fixed and already available in develop branch. Please, check the fix, if something doesn't work for you, feel free to reopen this issue.

okorshenko pushed a commit that referenced this issue Nov 10, 2017
Public Pull Requests

#11944 Report Handled Exceptions To New Relic by @mpchadwick
#12144 Removed FileClassScannerTest dependency to "Magento_Catalog" by @wexo-team
#11914 [BACKPORT 2.2] [BUGFIX] All UI input fields should have maxlength of 255 because of V… by @lewisvoncken

Fixed Public Issues

#11230 Unit test fails after fresh installation
#6238 Meta description allows too many characters
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Zaylril. Thank you for your report.
The issue has been fixed in #29429 by @Nazar65 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

6 participants