Skip to content

Wrong linefeeds #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amenk opened this issue Aug 24, 2015 · 3 comments
Closed

Wrong linefeeds #1730

amenk opened this issue Aug 24, 2015 · 3 comments

Comments

@amenk
Copy link
Contributor

amenk commented Aug 24, 2015

There seem to be some wrong line feeds (I installed via composer)

warning: CRLF will be replaced by LF in public/app/code/Magento/Catalog/view/adminhtml/web/catalog/category-selector.css.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/_files/product_with_custom_options.csv.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/app/code/Magento/ImportExport/Files/Sample/catalog_product.csv.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/app/code/Magento/Sales/view/adminhtml/layout/sales_order_creditmemo_new.xml.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/app/code/Magento/Ui/view/base/web/js/grid/listing.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/module/_footer.less.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/dev/tests/integration/testsuite/Magento/Indexer/Model/Config/_files/indexer.xml.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in public/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/general/line_endings_crlf.php.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/magento-composer-installer/res/target.xml.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/magento2-base/dev/tests/integration/testsuite/Magento/Indexer/Model/Config/_files/indexer.xml.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in public/vendor/magento/magento2-base/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/general/line_endings_crlf.php.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/module-catalog-import-export/Test/Unit/Model/Import/Product/Type/_files/product_with_custom_options.csv.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/module-catalog/view/adminhtml/web/catalog/category-selector.css.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/module-import-export/Files/Sample/catalog_product.csv.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/module-sales/view/adminhtml/layout/sales_order_creditmemo_new.xml.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/module-ui/view/base/web/js/grid/listing.js.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/theme-adminhtml-backend/Magento_Backend/web/css/source/module/_footer.less.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in public/vendor/magento/zendframework1/library/Zend/Queue/Adapter/Db/postgresql.sql.
@mazhalai
Copy link
Contributor

@amenk thank you for reporting this issue, but can you please give us more details how to reproduce this issue?

@amenk
Copy link
Contributor Author

amenk commented Aug 25, 2015

I saw it when committing to the Git. It is just about the line endings in those files.

@vpelipenko vpelipenko added the PS label Aug 25, 2015
@piotrekkaminski
Copy link
Contributor

@amenk is it still an issue? I haven't seen this problem

magento-team pushed a commit that referenced this issue Nov 16, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83959: Issue: 3596. Resolve Notice with undefined index 'value' #12296
 - MAGETWO-83957: #12083: Cannot import zero (0) value into custom attribute #12283
 - MAGETWO-83868: 11941: Invoice for products that use qty decimal rounds down to whole number. #11997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants