-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Child theme does not inherit translations from parent theme #17833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @rossmc. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @rossmc do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@rossmc, thank you for your report. |
#khcd2018 |
@SavchenkoVladimir thank you for joining. Please accept team invitation here and self-assign the issue. |
Hi @vpodorozh. Thank you for working on this issue.
|
#mageconf |
This commit |
…theme (cherry picked from commit 388fb45)
… theme - fix code style
… theme - fix code style
… theme (cherry picked from commit 21f5225)
… theme - fix php7.0 compatibility
Hi @rossmc. Thank you for your report.
The fix will be available with the upcoming 2.3.1 release. |
… theme - fix code style
… theme - take into account into "null" locale value
… theme - forward port unit tests from 2.2-develop branch
… theme - forward port unit tests from 2.2-develop branch - declare strict types
… theme - fix code style
Hi @rossmc. Thank you for your report. The fix will be available with the upcoming 2.3.1 release. |
Hi @rossmc. Thank you for your report.
The fix will be available with the upcoming 2.2.8 release. |
…me does not inherit translations from parent theme #19023
Uh oh!
There was an error while loading. Please reload this page.
Summary of the issue
Theme inheritance does not work as expected with translation dictionaries. The child theme does not use any translations defined in it's parent theme's
en_US.csv
translation dictionary.Preconditions
I'm working on a Magento ver 2.2.5 installation with two websites & two corresponding theme's. Each with their own translation dictionary, and one theme inheriting from the other.
Steps to reproduce
"Create New Customer Account","Create New Account"
to the parent theme'sen_US.csv
translation dictionary.Expected result
The page title should be Create New Account
Actual result
The page title is still Create New Customer Account
"Create New Customer Account","Create New Account"
to the Child theme'sen_US.csv
translation dictionary you can see the translation string applied corectly on the website with the child theme applied.Is this a bug with Magento or am I doing something wrong?
Is the translation dictionary documentation incorrect and this is actually the correct behaviour?
Theme Structure
Parent's theme.xml
Child's theme.xml
The text was updated successfully, but these errors were encountered: