Skip to content

Enable Translate Inline only per-session #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colinmollenhour opened this issue Jan 3, 2013 · 5 comments
Closed

Enable Translate Inline only per-session #183

colinmollenhour opened this issue Jan 3, 2013 · 5 comments

Comments

@colinmollenhour
Copy link

The Translate Inline feature is awesome. However, to use it in production is a little problematic since it uses an ip filter to enable it. In an office environment there are easily multiple users using the site simultaneously, some of which should not be allowed to use the inline translate feature and some of which need it disabled so they can use the site. It would be better if the inline translate feature required a specific admin user permission and was enabled by perhaps visiting a special url, or clicking a url/button in the backend that forwarded to a page with the feature enabled only for the given session.

Example:

  1. Admin user clicks "Start Translate Inline" with a given store scope specified.
  2. A nonce key is generated and stored in the database.
  3. The user is forwarded to the selected store home page with the nonce key in a get parameter.
  4. The nonce key is verified and deleted and inline translation is enabled for the user via a session flag.
  5. The user clicks a "Stop Translating" button to return to normal usage.
@magento-team
Copy link
Contributor

Hello Colin. Great feature request, unfortunately not on our roadmap for now. If you can contribute such enhancement we should be able to accept it.

@paales
Copy link
Contributor

paales commented Jan 11, 2013

There is a related problem with the translations and caching. If you for example want to translate something in the header it requires you to disable the cache for everyone on the site (or else you are unable to translate the header or after cache clearing everyone else has the {{{ tags in the header), so in an ideal case the cache should be disabled for the session that is currently translating.

@magento-team
Copy link
Contributor

Hello @paales - which cache you need to disable?

@paales
Copy link
Contributor

paales commented Feb 20, 2013

Translation cache would be handy 😉. The header and footer are block-cached (in Magento 1) so the block cache should be disabled as well.

@magento-team
Copy link
Contributor

@paales Unfortunately this is not on our roadmap but we encourage everyone to provide a pull request with fix.

vpelipenko added a commit that referenced this issue Mar 23, 2015
mazhalai added a commit that referenced this issue Nov 17, 2015
…URL-with-https-is-enabled-with-errors

[Ogres] Bugfixes
magento-engcom-team added a commit that referenced this issue Nov 7, 2018
 - Merge Pull Request magento/graphql-ce#183 from magento/graphql-ce:174_absolute_image_paths_for_products
 - Merged commits:
   1. 0400e32
   2. 277c81f
   3. 819b117
   4. a636914
   5. 0d191b7
   6. 7867e91
   7. bb4f601
   8. 3d3b45f
   9. c366d47
   10. 0a9977f
   11. b28d74a
   12. 10fdcfc
   13. 3196ebc
   14. ddb64a5
   15. 32baeb4
magento-devops-reposync-svc pushed a commit that referenced this issue Dec 20, 2023
Merging to create more changes to the task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants