Skip to content

Magento 2.2.6: cookies.js blocked > Minicart not working, infinite checkout loader. #18636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NostiLoke opened this issue Oct 15, 2018 · 13 comments
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue

Comments

@NostiLoke
Copy link

NostiLoke commented Oct 15, 2018

Preconditions (*)

  1. PHP 7.1
  2. Fresh Magento 2.2.6 installtion (without and with sample data) - no admin settings changed
  3. AdBlock-Extension in Chrome

Steps to reproduce (*)

  1. Reload page (F5)
  2. Add article to cart
  3. Go to checkout

Expected result (*)

  1. Article (and number) should be shown in the minicart.
  2. Link with the "Proceed to Checkout" is visible
    0043
  3. Checkout is useable and loader disappers after page is loaded

Actual result (*)

  1. Adblock activated. After page load "/mage/cookies.js net::ERR_BLOCKED_BY_CLIENT"
    [ERROR] Failed to load the "Magento_Checkout/js/view/minicart" component.
    0041

  2. After adding article to cart, minicart is shown as empty (and with no numer).
    0042

  3. After opening the /checkout/ manually - cookies.js still is blocked, loader doesn't disapear
    0044

0045

Similar issues where "real tracking" was blocked, but not cookies.js:
Solutions don't help with this issue:

Checkout 'hangs' in paymentstep when adblocker blocks Magento google-analytics javsascript file. #11208
Fix infinite checkout loader when some script wasn't loaded correctly because of network error #14874

@magento-engcom-team
Copy link
Contributor

Hi @NostiLoke. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@NostiLoke do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 15, 2018
@NostiLoke
Copy link
Author

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @NostiLoke. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @NostiLoke, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18636-2-2-6//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@NostiLoke
Copy link
Author

NostiLoke commented Oct 17, 2018

0046

The issue is reproduceable.
Adblock blocks the cookies.js - this results in:
[ERROR] Failed to load the "Magento_Checkout/js/view/minicart" component.

Reason is an entry in the Fanboy's Annoyance List
/mage/cookies.
https://easylist.to/easylist/fanboy-annoyance.txt

@ghost ghost self-assigned this Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 25, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 25, 2018
@DanielRuf
Copy link
Contributor

Reason is an entry in the Fanboy's Annoyance List
/mage/cookies.
https://easylist.to/easylist/fanboy-annoyance.txt

Which should be changed there. Not an issue on our side.

@ghost ghost added the non-issue label Oct 25, 2018
@NostiLoke
Copy link
Author

the cookies.js is also blocked in magento 1.9., but this doesn't break the checkout.
Is the cookies.js so important that therefore the "Magento_Checkout/js/view/minicart" component can't be loaded?
Blocking google analytics ends in the same issue: #12428
Sounds like an problem with handling the blocked components like described in similar posts mentioned above.

@DanielRuf
Copy link
Contributor

Yes it is a required dependency for other modules and to handle the cookies.
This is how requireJS works.

There might be (good) reasons why they added it to the blocklist.
In general I do not get this issue with the default setup of uBlock origin.

@DanielRuf
Copy link
Contributor

See https://github.com/magento/magento2/blob/2.3-develop/lib/web/mage/cookies.js.
It is directly referenced in the sidebar of the checkout and page-cache.

@DanielRuf
Copy link
Contributor

Not sure why this was added just because of one website / domain.
easylist/easylist@0ceae38

DanielRuf referenced this issue in easylist/easylist Oct 25, 2018
@DanielRuf
Copy link
Contributor

DanielRuf commented Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue
Projects
None yet
Development

No branches or pull requests

3 participants