UrlRewrite removes query string from url, if url has trailing slash

[sergeynezbritskiy]

Preconditions (*)

When customer opens url with trailing slash and query string like http://magento-host.com/some-url-key/?foo=bar, Magento redirects to url without trailing slash and truncates query string, so customer is redirected to http://magento-host.com/some-url-key.

1. Magento version 2.2.5 or 2.2.6
2. No customizations for the store, Luma + Sample Data

Steps to reproduce (*)

1. Open any product or category page.
2. Manually add /?foo=bar&bar=baz to the url and open this link

Expected result (*)

1. After the page has been loaded, query string remain in url

Actual result (*)

1. Query string is removed from url

Additional information

1. The issue is not reproduced when we avoid using url rewrites, e.g. http://magento-host.com/catalog/product/view/id/{product-id}/?foo=bar&bar=baz, and actually there is no redirect in this case.
2. The issue seems to be happen in \Magento\UrlRewrite\Model\Storage\DbStorage::doFindOneByData

$data[UrlRewrite::REQUEST_PATH] = [
    rtrim($requestPath, '/'),
    rtrim($requestPath, '/') . '/',
];

We are looking for both urls (with trailing slash and without it), but when verifying the result from database we do not check it.

// If request path matches the DB value or it's redirect - we can return result from DB
$canReturnResultFromDb = ($resultFromDb[UrlRewrite::REQUEST_PATH] === $requestPath || in_array((int)$resultFromDb[UrlRewrite::REDIRECT_TYPE], $redirectTypes, true));

[magento-engcom-team]

Hi @sergeynezbritskiy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@sergeynezbritskiy do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[sergeynezbritskiy]

https://github.com/sergeynezbritskiy/magento2/commit/7e26ec6a7cf1de8343ab05555de5a687da1518b8
Actually, I think this would be a fix for this issue. If this would be confirmed as a bug, then I will cover this fix with tests and will make a pull-request.
Thanks!

[orlangur]

@sergeynezbritskiy, URLs like http://magento-host.com/catalog/product/view/id/{product-id}/?foo=bar&bar=baz is not the right way to go. It should look like http://magento-host.com/catalog/product/view/id/{product-id}/foo/bar/bar/baz/ instead.

[sergeynezbritskiy]

@orlangur actually we can't change url format due to our SEO team restrictions. Moreover default magento layered navigation uses urls with query string, e.g. here is url from my local demo installation with sample data: http://demo.magento2.local/women/tops-women/jackets-women?climate=202; When I add trailing slash (http://demo.magento2.local/women/tops-women/jackets-women/?climate=202, which is actually a valid url in terms of http protocol),Magento redirects me to http://demo.magento2.local/women/tops-women/jackets-women.
I our case, we have a custom layered navigation module, which prettifies a little query string, making it like http://my-host.com/category-url-key?color=black&size=xl
But
We have a lot of promotion compains in social networks and Google, and generate these urls for these compains within some external ERP system, which actually creates urls with trailing slash, like http://my-host.com/category-url-key/?color=black&size=xl

[sergeynezbritskiy]

@orlangur due to my investigation, the issue probably comes from \Magento\UrlRewrite\Model\Storage\DbStorage:doFindOneByData, which returns 301 redirect for request_path with trailing slash, when it founds url rewrite with exactly the same request_path but without trailing slash, but not clear why the should be any redirect.
So comparing without slashes fixes the issue. Please check my commit https://github.com/sergeynezbritskiy/magento2/commit/7e26ec6a7cf1de8343ab05555de5a687da1518b8

[magento-engcom-team]

Hi @engcom-backlog-andrii. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.