Skip to content

Issue with configurable products in widgets, not added to cart #19315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcourtei opened this issue Nov 21, 2018 · 6 comments
Closed

Issue with configurable products in widgets, not added to cart #19315

jcourtei opened this issue Nov 21, 2018 · 6 comments
Assignees
Labels
Component: Catalog Component: CatalogWidget Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@jcourtei
Copy link

jcourtei commented Nov 21, 2018

Preconditions (*)

Version 2.2.6 (Community Edition).

Steps to reproduce (*)

  1. Create a product attribute, for example Size with several values (S, M and L). This attribute must have property "use in product listing" set to Yes.
  2. Create a product that uses this attribute with a configuration setting. Define different quantities for each values. Set this product as new for the current month.
  3. Create a block with a widget for new products (choose the grid template) and add this block at any page.
  4. On this page click on Add to cart (from a computer, not smartphone) for this new product.

Expected result (*)

User should see the product page with the message "You need to choose options for your item."

Actual result (*)

User is redirected to the cart page and the product is not added to the cart.

I think the issue is in vendor/magento/module-catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml.
I replaced :
<?php if ($_item->getTypeInstance()->hasRequiredOptions($_item)): ?>
with :
<?php if (!$_item->getTypeInstance()->isPossibleBuyFromList($_item)): ?>
This way it is consistent with Magento\Catalog\Block\Product\AbstractProduct->getAddToCartUrl(), since this method uses isPossibleBuyFromList() to choose the url.

Several templates are concerned with this issue :

  • vendor/magento/module-catalog-widget/view/frontend/templates/product/widget/content/grid.phtml (for the widget "Catalog Products List")
  • vendor/magento/module-catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml (for the widget "Catalog New Products List" with "New Products Grid Template")
  • vendor/magento/module-catalog/view/frontend/templates/product/widget/new/content/new_list.phtml (for the widget "Catalog New Products List" with "New Products List Template")
  • vendor/magento/module-catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml (for the widget "Catalog New Products List" with "New Products Images and Names Template")
@magento-engcom-team
Copy link
Contributor

Hi @jcourtei. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@jcourtei do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 21, 2018
@orlangur
Copy link
Contributor

orlangur commented Nov 22, 2018

@jcourtei suggested code changes can be provided directly as pull request. Thanks for bug report!

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 22, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost self-assigned this Nov 22, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Catalog Component: CatalogWidget Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96575, MAGETWO-96576 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 22, 2018
@ghost ghost removed their assignment Nov 22, 2018
@gelanivishal gelanivishal self-assigned this Nov 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team
Copy link
Contributor

Hi @jcourtei. Thank you for your report.
The issue has been fixed in #19322 by @gelanivishal in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: CatalogWidget Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants