Skip to content

Fixed configurable product widget issue #19322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

gelanivishal
Copy link
Contributor

Description (*)

Fixed issue configurable products in widgets.

Fixed Issues (if relevant)

  1. Issue with configurable products in widgets, not added to cart #19315: Issue with configurable products in widgets, not added to cart

Manual testing scenarios (*)

  1. Create a product attribute, for example Size with several values (S, M and L). This attribute must have property "use in product listing" set to Yes.
  2. Create a product that uses this attribute with a configuration setting. Define different quantities for each values. Set this product as new for the current month.
  3. Create a block with a widget for new products (choose the grid template) and add this block at any page.
  4. On this page click on Add to cart for this new product.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3516 has been created to process this Pull Request

Copy link

@jcourtei jcourtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In new_default_list.phtml it should be $_product instead of $_item

@gelanivishal
Copy link
Contributor Author

@jcourtei I have updated it.

Copy link

@jcourtei jcourtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gelanivishal Thanks!

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants