-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Missed form validation in Admin Order Address Edit route sales/order/address #19360
Copy link
Copy link
Closed
Labels
Component: CustomerFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Description
Activity
Metadata
Metadata
Assignees
Labels
Component: CustomerFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Preconditions (*)
Magento 2.2.*
EAV validation rules are not checked during editing an address in order.
route: sales/order/address
See column validate_rules in table customer_eav_attribute
e.g. name may have '{"max_text_length":255}'
Controller: \Magento\Sales\Controller\Adminhtml\Order\AddressSave::execute
This rules work in other forms on fronted and in address form and during creating new order from Admin
route: sales/order_create/index/
Steps to reproduce (*)
Expected result (*)
Shipping Address: "First Name" length must be equal or less than 255 characters.
Billing Address: "First Name" length must be equal or less than 255 characters.
Actual result (*)
UPD: so on the screenshot there is concatination with lastname.
Max length in DB is 255 so it relates to max value.
But if we set the rule to e.g. 100 symbols in customer_eav_attribute it's still possible to save 255 characters from this form