Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #19925

cedarvinda · 2018-12-21T11:26:04Z

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout

Preconditions (*)

Magento 2.3.0
PHP 7.2

Steps to reproduce (*)

Steps to reproduce
Note : testing should be in tab view or mobile view
Step 1: Go to frontend
Step 2: login as customer
Step 3: now add any product to cart and go to checkout
Step 4: in shipping address steps, you will see an saved address
Step 5: now click on add new address button or edit any saved address, then popup will open
(Now see actual result screenshot)

Expected result (*)

Actual result (*)

magento-engcom-team · 2018-12-21T11:26:08Z

Hi @cedarvinda. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@cedarvinda do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

magento-engcom-team · 2018-12-21T11:26:13Z

Hi @GovindaSharma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

GovindaSharma · 2018-12-21T11:28:03Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2018-12-21T11:28:07Z

Hi @GovindaSharma. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2018-12-21T11:28:36Z

Hi @GovindaSharma, here is your Magento instance.
Admin access: https://i-19925-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team · 2018-12-21T11:41:08Z

@GovindaSharma Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97283, MAGETWO-97284 were created

…address label whenever any user adding new shipping address in mobile view in checkout #19926 - Merge Pull Request #19926 from cedarvinda/magento2:2.3-DevelopPR3 - Merged commits: 1. e60a01d

…address label whenever any user adding new shipping address in mobile view in checkout #19926 - Merge Pull Request #19926 from cedarvinda/magento2:2.3-DevelopPR3 - Merged commits: 1. e60a01d 2. bd65344

…address label whenever any user adding new shipping address in mobile view in checkout #19926

@pmclain

Accepted Public Pull Requests: - #20050: Add missing throws to PHPDoc (by @pmclain) - #20046: Added constants to unit codes to make it easier to reuse it if necessary (by @tiagosampaio) - #20022: [Fixed Radio alignment issue on Cart page #20021] (by @hitesh-wagento) - #19792: Fixed 19791: Logo vertical misalignment. (by @suryakant-krish) - #20005: Minor Typo fix in AbstractFilter.php (by @ajeetsinghcedcoss) - #19981: Fix issue 19887 creating new shipment: getting all trackers. (by @Nazar65) - #19978: Set correct email message encoding (by @4lexvav) - #19941: issue resolved:Undefined Variable $itemsOrderItemId (by @GovindaSharma) - #19799: Fix issue 19796 - Sales Order invoice Update Qty's Button is misaligned (by @speedy008) - #19914: Move website_name column into columnSet (by @bradleyfrye) - #19926: fixed issue #19925 Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout (by @cedarvinda) - #19929: Refactoring in Magento_SalesRule (by @agorbulin) - #19900: Fix negative credit memo #19899 (by @wojtekn) - #19752: Fixed Typo error avaialble -> available (by @gulshanchitranshcedcoss) - #19715: [TASK] Updated the implements for the Magento_Cms Adminhtml Controllers (by @lewisvoncken) - #19620: Fix issue causing attribute not loading when using getList (by @MiliTree) - #19467: Use semantic theme color variables, including global primary/secondary colors (by @Brengineer) - #19930: Refactoring magento sales sequence (by @agorbulin) - #19646: Area Frontend: Fixed checkbox alignment account information page. (by @suryakant-krish) Fixed GitHub Issues: - #20037: CategoryLinkReposity does not list all possible exceptions (reported by @troendheim) has been fixed in #20050 by @pmclain in 2.3-develop branch Related commits: 1. d08ce91 2. a1d3299 - #20021: Radio alignment issue on Cart page (reported by @hitesh-wagento) has been fixed in #20022 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 6089f27 - #19791: Logo vertical misalignment. (reported by @suryakant-krish) has been fixed in #19792 by @suryakant-krish in 2.3-develop branch Related commits: 1. 485b89f 2. 3a56397 3. 8e59e4b - #19887: creating new shipment: gettting all trackers. after this commit 2307e16 (reported by @aldf) has been fixed in #19981 by @Nazar65 in 2.3-develop branch Related commits: 1. 8048516 2. 9cf1e3e - #19977: E-Mail subject not showing utf-8 characters (reported by @4lexvav) has been fixed in #19978 by @4lexvav in 2.3-develop branch Related commits: 1. bccc949 - #19940: Exception undefined variable itemsOrderItemId while creating shipment through MSI (reported by @mohammadzakir) has been fixed in #19941 by @GovindaSharma in 2.3-develop branch Related commits: 1. b54ab2d - #19796: Sales Order invoice Update Qty's Button is misaligned (reported by @speedy008) has been fixed in #19799 by @speedy008 in 2.3-develop branch Related commits: 1. e30a080 2. 8a3fa61 - #19899: Credit memo for $0 order without refunded shipping produces negative credit memo (reported by @wojtekn) has been fixed in #19900 by @wojtekn in 2.3-develop branch Related commits: 1. e840e41 2. 4a77f29 3. 5b4fdca - #17759: M2.2.5 : CustomerRepository::getList() does not load custom attribute if the name is "company" (reported by @kanduvisla) has been fixed in #19620 by @MiliTree in 2.3-develop branch Related commits: 1. d600179 2. b99af38 3. e29c5dd - #19645: Area Frontend: Account information page checkbox alignment issue. (reported by @suryakant-krish) has been fixed in #19646 by @suryakant-krish in 2.3-develop branch Related commits: 1. 0811a71

…n shipping address label whenever any user adding new shipping address in mobile view in checkout #20083 - Merge Pull Request #20083 from GovindaSharma/magento2:2.2-develop-PR-port-19926 - Merged commits: 1. 39a7405 2. 8ecf64f

…n shipping address label whenever any user adding new shipping address in mobile view in checkout #20083

m2-assistant · 2019-08-30T20:36:58Z

Hi @rodrigowebjump. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

00F100 · 2019-08-30T20:38:06Z

i work to make this fix

00F100 · 2019-08-30T20:54:00Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-08-30T20:54:02Z

Hi @00F100. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-08-30T20:54:38Z

Hi @00F100, here is your Magento instance.
Admin access: https://i-19925-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

00F100 · 2019-08-30T21:01:52Z

I performed the test and did not find this problem

thurow · 2019-09-14T16:18:11Z

Looks like this issue is already fixed. As you can see in the screenshot below, theres not an overlapping anymore.
Firefox:

Chrome:

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 21, 2018

GovindaSharma self-assigned this Dec 21, 2018

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 21, 2018

magento-engcom-team pushed a commit that referenced this issue Jan 4, 2019

ENGCOM-3731: fixed issue #19925 Close button overlapping in shipping …

fc809a6

…address label whenever any user adding new shipping address in mobile view in checkout #19926

magento-engcom-team pushed a commit that referenced this issue Jan 10, 2019

ENGCOM-3789: [Backport] fixed issue #19925 Close button overlapping i…

e759dba

…n shipping address label whenever any user adding new shipping address in mobile view in checkout #20083

sdzhepa unassigned GovindaSharma Jun 21, 2019

slavvka added the good first issue label Aug 23, 2019

rodrigowebjump self-assigned this Aug 30, 2019

rodrigowebjump removed their assignment Aug 30, 2019

thurow closed this as completed Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #19925

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #19925

cedarvinda commented Dec 21, 2018

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018 •

edited by GovindaSharma

Loading

Uh oh!

GovindaSharma commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

m2-assistant bot commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

magento-engcom-team commented Aug 30, 2019

Uh oh!

magento-engcom-team commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

thurow commented Sep 14, 2019

Uh oh!

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #19925

Close button overlapping in shipping address label whenever any user adding new shipping address in mobile view in checkout #19925

Comments

cedarvinda commented Dec 21, 2018

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018 • edited by GovindaSharma Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GovindaSharma commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

magento-engcom-team commented Dec 21, 2018

Uh oh!

m2-assistant bot commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

magento-engcom-team commented Aug 30, 2019

Uh oh!

magento-engcom-team commented Aug 30, 2019

Uh oh!

00F100 commented Aug 30, 2019

Uh oh!

thurow commented Sep 14, 2019

Uh oh!

magento-engcom-team commented Dec 21, 2018 •

edited by GovindaSharma

Loading