Skip to content

Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitrii-fediuk opened this issue Oct 22, 2015 · 6 comments
Closed

Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? #2156

dmitrii-fediuk opened this issue Oct 22, 2015 · 6 comments
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dmitrii-fediuk
Copy link

magento2/app/code/Magento/Translation/Model/Js/DataProvider.php

Line 63 in 0be91a5

\Magento\Framework\Phrase\Renderer\Translate $translate,

This lead to the 2 problems:

  • Inline translation does not work for Knockout templates.
  • Custom translators (which can be injected as an argument for \Magento\Framework\Phrase\Renderer\Composite) do not work for Knockout templates.
@dmitrii-fediuk dmitrii-fediuk changed the title Why does \Magento\Translation\Model\Js\DataProvider uses \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? Oct 22, 2015
@antonkril
Copy link
Contributor

Agree, but RendererInterface should be used instead of Renderer\Composite

@vkorotun vkorotun removed the PS label Aug 4, 2016
@IlnitskiyArtem
Copy link

@dmitry-fedyuk, Thanks for reporting this issue.
Created internal issue MAGETWO-70240 to investigate and track this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 27, 2017
@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed TECH labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@dmitry-fedyuk, thank you for your report.
We've created internal ticket(s) MAGETWO-70240 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 20, 2017
@dverkade dverkade mentioned this issue Nov 3, 2017
Merged
@okorshenko
Copy link
Contributor

Hi @dmitry-fedyuk. Thank you for your report.
The issue has been fixed in #12007 by @dverkade in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 26, 2017
magento-team pushed a commit that referenced this issue Dec 26, 2017
MAGETWO-85958: Fix #2156 Js\Dataprovider uses the RendererInterface. #…
4587233 
…12007

 - Merge Pull Request #12007 from dverkade/magento2:Change_Js_Dataprovider
 - Merged commits:
   1. db0c775
magento-team pushed a commit that referenced this issue Dec 26, 2017
MAGETWO-85958: Fix #2156 Js\Dataprovider uses the RendererInterface. #…
a107dbf 
…12007
This was referenced Jan 2, 2018
Merged
Merged
@magento-team
Copy link
Contributor

Hi @dmitry-fedyuk. Thank you for your report.
The issue has been fixed in #12953 by @dverkade in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 5, 2018
magento-team pushed a commit that referenced this issue Jan 5, 2018
@dmanners
MAGETWO-86286: [Backport to 2.2-develop] Fix #2156 Js\Dataprovider us…
8393022 
…es the RendererInterface. #12953

 - Merge Pull Request #12953 from dverkade/magento2:2.2-Fix-Js-Dataprovider-uses-the-RendererInterface
 - Merged commits:
   1. cfce631
magento-team pushed a commit that referenced this issue Jan 5, 2018
@ishakhsuvarov
MAGETWO-86286: [Backport to 2.2-develop] Fix #2156 Js\Dataprovider us…
813a49f 
…es the RendererInterface. #12953
@magento-team
Copy link
Contributor

Hi @dmitry-fedyuk. Thank you for your report.
The issue has been fixed in #12954 by @dverkade in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jan 11, 2018
magento-team pushed a commit that referenced this issue Jan 11, 2018
@dmanners
MAGETWO-86285: [Backport to 2.1-develop] Fix #2156 Js\Dataprovider us…
0531372 
…es the RendererInterface. #12954

 - Merge Pull Request #12954 from dverkade/magento2:2.1-Fix-Js-Dataprovider-uses-the-RendererInterface
 - Merged commits:
   1. 65c99b9
   2. f215350
   3. a0b7bc5
magento-team pushed a commit that referenced this issue Jan 11, 2018
MAGETWO-86285: [Backport to 2.1-develop] Fix #2156 Js\Dataprovider us…
4a98c46 
…es the RendererInterface. #12954
@vpodorozh vpodorozh mentioned this issue Apr 13, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@dmitrii-fediuk @antonkril @magento-team @veloraven @vzabaznov @okorshenko @vkorotun @MomotenkoNatalia @IlnitskiyArtem @magento-engcom-team