-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Elasticsearch6 generation does not exist #21916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @wclshashank. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @wclshashank do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
Hi @wclshashank the 2.3.1 release will be 26 how can you upgrade ? |
HI @engcom-backlog-nazar , Ok got it, I didn't check the release date and try to upgrade magneto2 version. Thanks. |
@wclshashank i'm closing this as magento 2.3.0 do not have Elasticsearch 6 module only develop branch. and on 2.3-develop have no this issue. |
Updated to 2.3.1 now and same error still appears. That file indeed did not exist |
hi @juharintanen i'm will recheck. |
Hi, I have this issue due to Amasty module. Amasty module using elasticsearch, which is making issue in compiling. Need to update Amasty module. Thanks |
Yep confirmed! |
@wclshashank found internal ticket where this was fixed, wait a little bit i'm share with pr. |
Hi, It looks like a bug to me. |
I have the same issue on 2.3.1:
Does this require a fix from Magento or from Amasty? @engcom-backlog-nazar please share the PR |
Hi @craigcarnell, I have the same error after run di:compile. if you have Extension Amasty Layered Navigation, you can to try to disable extension Amasty_Shopby and run di:compile. I hope it helps you. |
Hi @craigcarnell why reopen ? |
@engcom-backlog-nazar Because a fix has not been provided by Magento |
@engcom-backlog-nazar Do you have the PR you mentioned? I need this ASAP please |
@craigcarnell no, because this in private repository. https://github.com/magento/magento2ce/pull/3912/files#diff-b2e0d454e4ffd542fa96dc1b7dc225d9 |
@engcom-backlog-nazar Slightly confused, as you offered a fix above. Will create a ticket with Magento "Gold" support.. |
@engcom-backlog-nazar: can you please link to open sourced repo's please? It would be very interesting to see this fix as other tickets are being created which are probably caused by the same issue. Just link to commits in this repo if they have already been merged, that would be very much appreciated! |
Hi @engcom-backlog-nazar , Is there any update? |
I can confirm that this seems to be caused by a conflict with the Amasty_ShopBy plugin. I can get it to compile if I disable Amasty_ShopBy OR Magento_Elasticsearch6. |
@adamrandazzo so to have this issue we need just add a plugin to ElasticSearch 6 ? can you show where plugin defined ? |
Same issue when upgrading from 2.3.0 to 2.3.1 and same solution here - disable Amasty_Shopby and setup:di:compile completes without error |
I was able to reproduce and it is a general issue related to virtual types with names ending with any autogenerated suffix being pluginized on concrete class. |
Same problem. Not using Amasty_ShopBy ... |
Interesting tidbit: if I copy the Elasticsearch6 module into a Magento 2.3.0 installation with the unpatched Amasty module, the same problem occurs. So this is no new bug in 2.3.1. I also can confirm what @phoenix128 figured out, in that certain names of virtual types can not be used, if they end on for example The WIP fix unfortunately doesn't seem to resolve the problem in my testing. @maghamed: have you guys already found more info about this problem? |
I got the same error on 2.3.1. |
This error occurs after upgrading 2.3.1 and it is bug in Magento 2.3.1. If we see https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Elasticsearch6/etc/di.xml it is showing below code:
In above code it states "Magento\Elasticsearch6\Model\Adapter\FieldMapper\ProductFieldMapper" as a argument for productFieldMappers and no such model class file exists. Review below file path to verify it: https://github.com/magento/magento2/tree/2.3-develop/app/code/Magento/Elasticsearch6/Model/Adapter/FieldMapper To fix this issue, either we have to remove this code snippet or create a class file for the same. As per me, It is Magento issue and not relevant to Amasty. |
@bijalbhavsar : |
My PR (https://github.com/magento/magento2/pull/22046/files) is in WIP status, but I am almost there to fix it. Seems like the issue is divided in two different aspects and now I fixed just one of them. More precisely I just fixed it in the developer mode. Need to fix in production mode. |
Magento was not checking concrete class while applying plugins, this commit prevents virtual types to be autogenerated
Update: |
@sdzhepa Thank you for verifying the issue. Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:
Once all required information is added, please add label |
✅ Confirmed by @sdzhepa Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @wclshashank. Thank you for your report.
The fix will be available with the upcoming 2.3.2 release. |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: