-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Issue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Description
Summary
OrderPaymentInterface misses a setter for additional_information: this is an inconsistency between its schema declaration and the real properties accepted.
Examples
If you declare an API interface that accepts as a parameter an object of the type OrderPaymentInterface, additional_information property should be accepted.
The result is this error:
Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface".
Forcing developer to unset additional_information before sending this object
A validation of this schema can be triggered in this way:
- create an integration token in admin with permission over Sales > Order > Operation > Create
- use swagger interface to test this endpoint salesOrderRepositoryV1SavePutBody
- the exception
Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface".
will be triggered due the fact that additional_information property is defined (getAdditionalInformation() exists and swagger use that to define its sample call).
Proposed solution
Implement a setter setAdditionalInformation() in OrderPaymentInterface: model using this interface have already got this method.
Metadata
Metadata
Assignees
Labels
Issue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it