-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: ThemeFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentProgress: PR CreatedIndicates that Pull Request has been created to fix issueIndicates that Pull Request has been created to fix issueReported on 2.3.4Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
Preconditions (*)
- Magento 2.3.4
Steps to reproduce (*)
- Enable Critial CSS
- Validate html https://validator.w3.org/
Expected result (*)
- Validate html without error
Actual result (*)
- Validate html error
https://prnt.sc/qz5dz9
magento2/app/code/Magento/Theme/Controller/Result/AsyncCssPlugin.php
Lines 60 to 66 in 9544fb2
| $loadCssAsync = sprintf( | |
| '<link rel="preload" as="style" media="%s" . | |
| onload="this.onload=null;this.rel=\'stylesheet\'"' . | |
| 'href="%s">', | |
| $media, | |
| $href | |
| ); |
need change to
$loadCssAsync = sprintf(
'<link rel="preload" as="style" media="%s"
onload="this.onload=null;this.rel=\'stylesheet\'"' .
' href="%s">',
$media,
$href
);
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Component: ThemeFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentProgress: PR CreatedIndicates that Pull Request has been created to fix issueIndicates that Pull Request has been created to fix issueReported on 2.3.4Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch