Size swatches for sold out sizes missing in frontend

[MichaelThessel]

Preconditions (*)

1. 2.3.5-p2 (but also previously reported on 2.4)

Steps to reproduce (*)

1. Create config product with one color and several sizes
2. Make one size out of stock
3. Set Admin > Stores > Configuration > Catalog > Inventory > Stock Options > Display Out of Stock Products = Yes
4. Make size and color swatches

Expected result (*)

1. Out of stock sizes show in frontend as crossed out swatch

Actual result (*)

1. Out of stock swatches are missing entirely

This behavior is also inconsistent with config products with multiple colors. In that case the sizes render correctly with the option crossed out. In addition I think this should be independent from "Display Out of Stock Products". Either it always should show the crossed out swatches or this should be an independent config option.

This issue has been reported tons of times already but always has been closed incorrectly. Here a few examples:

#26673
#10454
#23196
#23196

Based on the ongoing activity in these tickets and that people keep filing tickets you can see that this still affects multiple users. This behavior is not only inconsistent with multi color config products but also with any other e-commerce platform out there. This is not only a visual problem but it actually prevents me from building additional functionality that depends on these options to be visible in the front end.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @MichaelThessel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[joshdavenport]

Really didn't want to leave a +1 type response here, but given the lack of attention this seems to have received over the last year or two I feel obliged to say that this is a real point of pain not just for us but apparently plenty of others too. We'd all highly value a fix for this.

Especially given in a recent upgrade from 2.2 to 2.3/2.4 previous workarounds we had in place are no longer working, it seems there are issues with community provided solutions too now.

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Alfa]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Alfa, here is your Magento Instance: https://11b5ffe465b673eb8224822ddfaf5ff4-2-4-develop.instances.magento-community.engineering
Admin access: https://11b5ffe465b673eb8224822ddfaf5ff4-2-4-develop.instances.magento-community.engineering/admin_369b
Login: 608c842a
Password: bb6d8c365d93

[engcom-Alfa]

Hi @MichaelThessel .

Unfortunately, we can't reproduce this issue on fresh 2.4-develop.
Everything works as expected.

Manual testing scenario:

1. Create config product with one color and several sizes
2. Make one size out of stock
3. Set Admin > Stores > Configuration > Catalog > Inventory > Stock Options > Display Out of Stock Products = Yes
4. Make size and color swatches

Actual Result: ✔️ Out of stock sizes show in frontend as crossed out swatch

@MichaelThessel Are you able to reproduce this issue on a fresh 2.4-develop instance?
Thanks!

[nordcomputer]

I dont know, if its the same issue, but all the swatches will be removed (instead of greyed out), if you set all sizes qty to 0
You can test it in the development instance.

[nordcomputer]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @nordcomputer. Thank you for your request. I'm working on Magento instance for you.

[joshdavenport]

Indeed. Basically hiding/showing of swatches based on the show/hide out of stock products config option is only half implemented. It should be obeyed fully in all scenarios or not at all.

[robbie-thompson]

@nordcomputer @joshdavenport +1 this behaviour is incredibly annoying and has gone on for too long for what is now a standard feature. I've created a separate issue here which I believe better addresses this scenario, as OP's refers to something different.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[nordcomputer]

I think, this behavior is still a thing...(magento 2.4.2) - so, I guess the stale-bot is wrong....

[df2k2]

I commented in a related issue, but I post here as well. I feel as though this is related to functionality using:

magento2/app/code/Magento/Swatches/Model/SwatchAttributeCodes.php

Line 70 in c364929

public function getCodes()

I wrote some code that used this method and then had to change it because when no options are available, the attribute is not recognized as a swatch attribute, so logic with comparisons will not work.

[MichaelThessel]

Commenting to create activity.

[danyvega1990]

I hope magento actually shows some interest on fixing this, they can say it's not a bug if they want, but just not giving a configuration that others e-commerce platforms provide feels wrong, plain and simple

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[robbie-thompson]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

Still relevant

[gino2014]

Still relevant ...

[drdreamm]

fix this please

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @MichaelThessel ,

Issue is not reproducible on Magento 2.4 Develop. Hence closed.

[nordcomputer]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @nordcomputer. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @nordcomputer, here is your Magento Instance: https://11b5ffe465b673eb8224822ddfaf5ff4-2-4-develop.instances.magento-community.engineering
Admin access: https://11b5ffe465b673eb8224822ddfaf5ff4-2-4-develop.instances.magento-community.engineering/admin_62fe
Login: 5e458989
Password: 2d50ad6ffec4

[nordcomputer]

@magento give me 2.4-develop instance without extensions magento/module-two-factor-auth

[magento-deployment-service]

Hi @nordcomputer, unfortunately there is no ability to deploy 2.4-develop Magento instance. Please make sure you specify the correct Magento version/branch.

[nordcomputer]

@magento give me 2.4-develop without extensions magento/module-two-factor-auth instance

[magento-deployment-service]

Hi @nordcomputer, unfortunately there is no ability to deploy 2.4-develop without extensions magento/module-two-factor-auth Magento instance. Please make sure you specify the correct Magento version/branch.

[nordcomputer]

@engcom-Delta - are you sure, that it is not reproducible?
It could be a bit tricky to reproduce....
I wanted to try myself, but I am not able to login to the develop instance because of 2-Factor -.-

[joshdavenport]

Getting reports in a recently upgrade 2.3 to 2.4 instance that this issue is cropping up again. I definitely recall seeing the issue no longer present in the instance provided to me here #30046 (comment) so this is pretty confusing.

Not sure if this has be re-introduced, or if there's perhaps a common customisation that introduces this issue, or who knows what.

@engcom-Delta any way that we can get @nordcomputer a 2.4 instance where 2fa isn't present or works so that they can re-verify this issue? Perhaps I missed something last year.

[pagesailor]

Still not working.