Skip to content

Why some translation is invalid, the other is valid in same file? #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SunshineTech opened this issue Jun 2, 2013 · 4 comments
Closed
Assignees

Comments

@SunshineTech
Copy link

In magento2, there are much magical thing. That is, in the same file, some translation is valid, the other is invalid(not display the locale text). For example:

  1. In app/code/Mage/Backend/view/adminhtml/widget/grid/extended.phtml, the translation of 'View'(line 99) and 'per page'(line 118) is invalid.
  2. In app/code/Mage/Backend/Block/Widget/Grid/Extended.php, the translation of 'Search'(line 214) is invalid.

I use zh_CN, in the locale file, both the valid and the invalid translation all exist.

@magento-team
Copy link
Contributor

Hello. What do you mean by valid/invalid translations? Is it quality of translator work? The files were translated by more than 1 person which could cause such issues.

@SunshineTech
Copy link
Author

In the same file, some text was translated, the other text was not translated.

@ideirj
Copy link

ideirj commented Jun 25, 2013

Hi,
If someone collects non-translated texts they will be corrected?

Example:
app\code\Mage\Persistent\view\frontend\remember_me_tooltip.phtml
What's this? --> __('What\'s this?'); ?>

@verklov
Copy link
Contributor

verklov commented Apr 17, 2014

We will update translations when preparing the release version. So far I can tell you that for cases when the string is not localized, means there is no translation and the English key is used for displaying the localized string.

@verklov verklov self-assigned this Apr 17, 2014
@maksek maksek added the CS label Nov 12, 2014
@maksek maksek removed the minor-check label Jan 8, 2015
@verklov verklov closed this as completed Jan 12, 2015
magento-team pushed a commit that referenced this issue May 22, 2015
[GoInc] MAGETWO-33531 M2 GitHub Update (version 0.74.0-beta9)
magento-team pushed a commit that referenced this issue Jan 15, 2016
mmansoor-magento pushed a commit that referenced this issue Aug 31, 2016
[Performance] Compiler Performance Optimisation
magento-engcom-team added a commit that referenced this issue Jan 24, 2019
 - Merge Pull Request magento/graphql-ce#302 from brendanfalkowski/graphql-ce:fix-spelling
 - Merged commits:
   1. 92b2cfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants