Skip to content

A logical and resource consumption issue in the \Magento\Ui\Component\Form\Element\Wysiwyg::__construct() method: the editorElement object in unnecessary set as property but in never used (and can not be used) outside the single method #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitrii-fediuk opened this issue Jan 28, 2016 · 4 comments
Assignees

Comments

@dmitrii-fediuk
Copy link

https://mage2.pro/t/389

@ktomk
Copy link
Contributor

ktomk commented Jan 30, 2016

There is also the flaw that the constructor does real work (ctor src).

The dependency injection layer is lacking a feature to provide all needed dependencies in this case -or- the type's design is flawed. Would be interesting to get some feedback about this from the developers, there are perhaps other places that are worth of a discussion, e.g. I ran over the case that I could have used the injection of a parameter from the registry which AFAIK is not supported by the DI layer as well (correct me if not :)).

@Mulderua
Copy link
Contributor

app/code/Magento/Ui/Component/Form/Element/Wysiwyg.php is no longer exist.

@NadiyaS NadiyaS closed this as completed Jun 21, 2016
@NadiyaS
Copy link
Contributor

NadiyaS commented Jun 21, 2016

Hi @ktomk ,

The GitHub issue tracker is intended for technical issues only. Please refer to the Community Forums or Magento Stack Exchange site for technical questions. In your case, the programming questions forum is likely the most appropriate. Feel free to reopen this issue if you think you have encountered a bug in Magento 2.

@ktomk
Copy link
Contributor

ktomk commented Jun 21, 2016

@NadiyaS: Jiust FYI, some people might find it offensive to be greeted with macro texts when they took the time to visit and give feedback to an issue. Per notifications, duplicate positings do also arrive even if deleted later on the Github platform. No worries please.

magento-engcom-team pushed a commit that referenced this issue Sep 20, 2018
[EngCom] Public Pull Requests - GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants