attribute option label / value comparison on api POST requests

[cfarnleitner]

Preconditions (*)

1. Magento 2.4.2

Steps to reproduce (*)

1. Create Dropdown type Product Attribute with values required yes. Ex: M, L, XL
2. Reindex and flush cach
3. POST request to /rest/all/V1/products/attributes/{attributeCode}/options
   Paylod:
   { "option": { "label": "XXL", "value": "", "sort_order": 0, "is_default": false, "store_labels": [ { "store_id": 1, "label": "XXL" } ] } }

Magento will return option ID as a response ('220' in my case).

4. If you try to call the API again with the same data, you should get the exception message, as you did, because you're trying to create duplicate labels.

5. But, if you try to create new label which is the same as option ID you received in the previous request, Magento returns an exception, because it compares existing option IDs for the attribute with the label that has been posted:
   Payload:
   { "option": { "label": "220", "value": "", "sort_order": 0, "is_default": false, "store_labels": [ { "store_id": 1, "label": "220" } ] } }

Instead of creating new attribute label, which would be expected behavior, Magento responds that the option already exist, which is incorrect:

{ "message": "Admin store attribute option label "%1" is already exists.", "parameters": [ "220" ], }

This is cased by comparing received option label with IDs of already existing options for that attribute, as @cfarnleitner already pointed out.

This doesn't happen from the admin UI because admin controller is using different logic than the API endpoint.

Expected result (*)

API should be working fine with 200 success code.
Note: There is no issue if added from admin UI

Actual result (*)

{ "message": "Admin store attribute option label "%1" is already exists.", "parameters": [ "220" ], }

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @cfarnleitner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[cfarnleitner]

So far i can tell that recreating getOptionId with an around-plugin, excluding || $option['value'] == $value from the condition has no negative impact on attribute option findings.

[m2-assistant]

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41620 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @cfarnleitner and @engcom-Oscar,

What happens if the request body contains the "value" field? As you mentioned, that value is required, if that is the case the request must specify it.

I believe the problem here could be related to wrong error handling instead.
Thanks.

[gabrieldagama]

Hi @cfarnleitner, I've tried to reproduce this issue on 2.4-develop and it seems to behave correctly to me.

I've managed to create a new attribute options using your request body, when tried to run it again (after the first option got created), I've received the exception that you mentioned, and that seems to be the same behavior as the admin.

If you try to create a new option with a label that already exists, I've got the The value of Admin must be unique. (000001) error on admin.

Can you double check this? Thanks!