RabbitMQ reject doesn't work on consumer exception

[madonzyaccenture]

Preconditions (*)

1. Magento 2.3.3

Steps to reproduce (*)

1. Run any bulk WEBAPI import
2. Start the consumer
3. Within consumer throw an exception

Expected result (*)

1. Message should returned to the queue

Actual result (*)

1. Message was not returned to the queue, thus lost

Here is a code that explains that if an exception was thrown, then reject the message: vendor/magento/module-asynchronous-operations/Model/MassConsumerEnvelopeCallback.php:120

I found that requeue argument is set to false, so I manually changed it to true for test purposes. The message was not requeued as well.

If that is expected behavior, please tell me how can I manipulate basic_ack and basic_nack/basic_reject within consumers? I also posted the question on StackOverflow: https://magento.stackexchange.com/questions/335005/magento-2-rabbitmq-ack-or-reject-message/335023#335023

Note: Either I set requeue as true or false the behaviour is same. Exceptions, don't get requeue whether requeue variable is set as true. Please Fix the implementation of requeue argument under reject method

[m2-assistant]

Hi @madonzyaccenture. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Golf. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Golf]

@madonzyaccenture As suggested rabbitMQ is configured, Product asynchronous bulk API /rest/async/bulk/V1/products is called.
Consumer async.operations.all queue is processed successfully without any exception.

Please note that MessageLockException, ConnectionLostException, NotFoundException exceptions are already handled.

Can you please assist me to reproduce the 3rd Step. Your exception occur at what time?

[madonzyaccenture]

@engcom-Golf just throw an \Exception and see if the message is removed from the queue. Actual behavior is that message is removed, but it's an issue as message was not proceed properly.

[engcom-Golf]

@madonzyaccenture This may not be an issue, It is actually an expected behaviour for all the Exceptions. If any Exception occur, It will be removed from Queue, Also proper Error Message will be shown in the Magento Admin panel - Bulk Log

Let me Explain you with Example.

1. I tried to insert 2 Products, having different SKUs but same URL KEY via Bulk Async API
   
   
   
   
   

Step 2: Consumer Started - bin/magento queue:consumers:start async.operations.all

Note: At this point of time, 2 messages has been queues in RabbitMQ.

Step 3: Only One Product has been saved, another couldn't be saved due to having same URL KEY

Thus, It shown error in the Admin Panel with proper reason.

Clarification required: If an Exception is thrown, currently It don't get ReQueue, but let say if we do ReQueue, again It will go to Exception. Then what's the point of ReQueue?

[madonzyaccenture]

@engcom-Golf nope, imagine that issue occurs not because of duplicated entity, but because we have some 3D party API that must be called before save, but currently is not responding, thus entity could not be saved. Developer need to decide to remove or requeue, currently we don't have such option. Messages will always be deleted.

[engcom-Golf]

@madonzyaccenture Thank you so much for detailed description.