Skip to content

File Uploader initialization #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trongrg opened this issue Aug 25, 2013 · 1 comment
Closed

File Uploader initialization #344

trongrg opened this issue Aug 25, 2013 · 1 comment

Comments

@trongrg
Copy link

trongrg commented Aug 25, 2013

app/code/Mage/Backend/Model/Config/Backend/File.php
95:                $uploader = new Mage_Core_Model_File_Uploader($file);

app/code/Mage/Catalog/Model/Category/Attribute/Backend/Image.php
63:            $uploader = new Mage_Core_Model_File_Uploader($this->getAttribute()->getName());

app/code/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Image.php
56:            $uploader = new Mage_Core_Model_File_Uploader($this->getAttribute()->getName());

app/code/Mage/Cms/Model/Wysiwyg/Images/Storage.php
325:        $uploader = new Mage_Core_Model_File_Uploader('image');

app/code/Mage/Downloadable/controllers/Adminhtml/Downloadable/FileController.php
53:            $uploader = new Mage_Core_Model_File_Uploader($type);

Those lines should be changed to use Mage::getModel instead of a direct 'new' keyword.

This will allow developers to easily implement new changes in File Uploader model.

I would love to provide the patch if necessary.

@verklov
Copy link
Contributor

verklov commented Dec 30, 2013

@trongrg , Sorry for the delay with the response. Due to the latest architectural changes we made in the system, the issue is not relevant any more.

@verklov verklov closed this as completed Dec 30, 2013
magento-team pushed a commit that referenced this issue Jun 12, 2015
[Firedrakes] Remove model related methods from Magento Object
magento-team pushed a commit that referenced this issue Feb 4, 2016
[WebDev] Bugfixes and Tasks
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issues:
MAGETWO-57136: [GitHub] Wrong initialization sequence in mage.priceBox widget (price-box.js) #6117
MAGETWO-57062: [Backport] - Issues with minicart in multiwebsite - for 2.1
MAGETWO-55184: [GitHub #5526]Selected category is not added to Cart Price Rule condition due to JS error
MAGETWO-57168: CLONE - [GitHub]JavaScript Error on Checkout Page after Changing Country in Estimate Shipping and Tax Block
MAGETWO-57843: [Backport] - [Github # 6294] Coupon code override cart rules with no coupon code - for 2.1
MAGETWO-57512: [Backport] - Giftcard Purchase - Order Status - Processing - for 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants