[php8.1 M2.4.4 EE] stripos expects parameter string, null given

[sheepfy]

Hi, so we have this:

1. This observer: Magento\PricePermissions\Observer\AdminhtmlBlockHtmlBeforeObserver::execute method have this part of code:

        /** @var $block Template */
        $block = $observer->getBlock();

        $this->_filterByBlockName($block);

        // Handle prices that are shown when admin reviews customers shopping cart
        if (stripos($block->getNameInLayout(), 'customer_cart_') === 0) {

2. The $block::getNameInLayout method is marked with annotation @return string. However, it can return NULL as well which can trigger an issue on php8 in stripos function.

My issue:
I'm using a 3rd party module that adds Tabs in it's admin form and I am thinking of adding this condition in AdminhtmlBlockHtmlBeforeObserver::execute :

if (!$block->getNameInLayout()) {
    return;
}

I don't think there is a reason to check anything in that observer if the block name is missing. (even if it's empty string).

Either that, either if the block name is not intended to be NULL update the getNameInLayout() to return only string.

[m2-assistant]

Hi @sheepfy. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @sheepfy,

Thanks for the posting and collaboration!

We have checked the usage of function setNameInLayout() defined in class lib/internal/Magento/Framework/View/Element/AbstractBlock.php from where $this->_nameInLayout is initialized but in the Magento core, no null value has been passed.

Please let us know which 3rd party module you have tried where you are facing the issue.

Thanks

[sheepfy]

@engcom-Hotel Hey, so it is about implementing Tab forms in admin.
Modules in case were Firebear and Xtento_ProductExport . They adds Tabs, tabs will have null as block name and they will fail in that observer.

However, since _nameInLayout can reach as null in that method output, I'll stick to this:
if (!$block->getNameInLayout()) {
return;
}

[engcom-Hotel]

Hello @sheepfy,

Thanks for the response!

I have tried to check the above-mentioned modules in Marketplace and found the below results:

• Firebear :- https://marketplace.magento.com/catalogsearch/result/?q=Fire%20bear
• Xtento_ProductExport :- https://marketplace.magento.com/xtento-productexport.html

I request you to please connect with them and raise a query for this. They might help you.

Thanks

[engcom-Hotel]

Dear @sheepfy,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

[sheepfy]

@engcom-Hotel hi, I don't think I can create a PR here with that fix tho, Magento\PricePermissions it's an enterprise module.

[kmosdev]

@sheepfy I had this same issue and created a patch for it.

This code can be saved as a .patch file and placed in /m2-hotfixes

diff --git a/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php b/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php
index 974b4ec..2ac0e01 100644
--- a/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php
+++ b/vendor/magento/module-price-permissions/Observer/AdminhtmlBlockHtmlBeforeObserver.php
@@ -120,7 +120,7 @@ class AdminhtmlBlockHtmlBeforeObserver implements ObserverInterface
         $block = $observer->getBlock();

         $this->_filterByBlockName($block);
-
+        if(empty($block->getNameInLayout())) { return; }
         // Handle prices that are shown when admin reviews customers shopping cart
         if (stripos($block->getNameInLayout(), 'customer_cart_') === 0) {
             if (!$this->observerData->isCanReadProductPrice()) {

[sheepfy]

@kmosdev Hi!
That's the patch that I've used, I'd go with "!$block->getNameInLayout()" since the return value is just a string|null and "!" is doing the same thing as "empty"

file: magentoroot/patches/composer/github-issue-35542.diff

diff --git a/Observer/AdminhtmlBlockHtmlBeforeObserver.php b/Observer/AdminhtmlBlockHtmlBeforeObserver.php
index 974b4ec..1978e66 100644
--- a/Observer/AdminhtmlBlockHtmlBeforeObserver.php
+++ b/Observer/AdminhtmlBlockHtmlBeforeObserver.php
@@ -118,6 +118,9 @@ class AdminhtmlBlockHtmlBeforeObserver implements ObserverInterface
     {
         /** @var $block Template */
         $block = $observer->getBlock();
+        if (!$block->getNameInLayout()) {
+            return;
+        }
 
         $this->_filterByBlockName($block);

file: magentoroot/composer.json

{
    [...]
    "extra": {
        [...]
        "patches": { 
            [...]
            "magento/module-price-permissions": {
                "skip composer execution for missing block name": "patches/composer/github-issue-35542.diff"
            },
            [...]
        }
        [...]
    }
    [...]
}