-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Consistant Location for index.php File #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👍 I agree with Alan. The inclusion of /pub was obvious to me but would likely be nonobvious for many. |
Both index.php are entry points and they are reusing the same The intended use cases:
|
I think Magento 2 should has one index.php in pub directory. It's more secure. |
Internal ticket: MAGETWO-32660 |
[NORD] MAGETWO-34125 Sample Data fix
What is the status of the internal ticket? |
See also #1874 |
No update since September of last year -- assuming this isn't a priority for the engineering team and closing out. |
Hey @astorm. I do understand the confusion it introduces and while we have plans to have single entry point, it is not a priority due to low impact and possibility of affecting many merchants using lower end hosting providers, who still (s)FTP the files and cannot change the webroot. Ideally everyone that can should be using pub as the entry point and I will ask to clarify this in the guides. |
Fixed issues: - MAGETWO-56910: Braintree doesn't work when using table prefixing - MAGETWO-57426: [Github] Braintree Vault payments causing GET order API to throw error - MAGETWO-56932: Checkout page freezes when ordering Virtual Gift Card with Authorize.net set to Authorize and Capture - MAGETWO-57037: UPS not providing shipping rates for Puerto Rico - MAGETWO-57086: [Github] #5910 Braintree sandbox errors when using alternative Merchant Account ID
- Merge Pull Request magento/graphql-ce#356 from magento/graphql-ce:GraphQL-352-is-email-available - Merged commits: 1. 0654c32 2. 6293ca7 3. a29ecf4
As it stands, Magento 2 currently ships with two index.php bootstrap files. One in the root folder
and one in the
pub
folderThis situation creates some uncertainty for end users of the system as to which folder should be exposed to their web-server. The includes of a
pub
folder will indicated to some developers that this should be the public webroot. However, developers not familiar with the concept will seeindex.php
in the root folder and assume this file should be exposed.With commenting on which approach is better, a single approach should be chosen for the file to reduce confusion in the system. A single location for the "index bootstrap" files should be chosen, and stuck to. (assuming, of course, there's is not an opaque-but-important reason for the current state of affairs)
The text was updated successfully, but these errors were encountered: