[Issue] [PHPDOC] Fix bad phpdoc Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs()

[m2-assistant]

This issue is automatically created based on existing pull request: #39581: [PHPDOC] Fix bad phpdoc Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs()

---

Description (*)

This PR fix the bad phpdoc for \Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs().

The argument $alias can be null or string.

Here is an example where the type null is used :

magento2/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php

Lines 2557 to 2562 in d06337a

	$attribute = $entity->getAttribute($attrCode);
	$attrFieldName = $attrTable . '.value';
	$fKey = $connection->quoteColumnAs($fKey, null);
	$pKey = $connection->quoteColumnAs($pKey, null);
	$condArr = ["{$pKey} = {$fKey}"];

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Questions or comments

The quality of Magento code needs to be improved so that it is easier to use the code quality tools (phpstan, rector, ...) ❤️

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[engcom-Dash]

@dimitriBouteille Thanks for the report and contribution!

Preconditions:
Install Fresh Magento 2.4-develop

Steps to reproduce:
Set up PHPSTAN with level 5 or higher and run the check.
vendor/bin/phpstan analyse app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php --level=5

Error is showing

Parameter #2 $alias of method Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs() expects string, null given.

Hence, Confirming the Issue.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.