Condition is never met in `\Magento\Framework\Escaper::escapeScriptIdentifiers`

[wubinworks]

Preconditions and environment

• Magento 2.4.x

Steps to reproduce

In \Magento\Framework\Escaper::escapeScriptIdentifiers:

Here and here, $filteredData === false will never be met since preg_replace only returns string|array|null.

See preg_replace documentation.

Expected result

Check if $filteredData is NULL.

Actual result

Check if $filteredData is false.

Additional information

Related commit.
#23988

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @wubinworks. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[engcom-November]

Hello @wubinworks ,

Thank you for the report and your collaboration.

However, the documents you shared are currently returning 404 errors. Could you please re-share the correct links at your earliest convenience?

In the meantime, we are marking this issue as "Needs Update."

Thank you again for your support!

[wubinworks]

@engcom-November Those broken links are fixed.

[engcom-November]

Hello @wubinworks

Thank you for updating the links.

I have reviewed the provided documentation and links, and I can confirm the issue.

And we attempt to reproduce in our latest 2.4-develop instance and issue is reproducible and here is the watched screenshot for the reference

Accordingly, I am marking this as "Issue: Confirmed."

Thank you!