Repository navigation
ShippingAddressPersister overwrites edited shipping address during Admin Reorder #41624
Description
Preconditions and environment
- Magento version: 2.4.9 (also reproduced on 2.4.8-p5; cannot reproducible on 2.4.6-p14)
- 2 different tax rate, for example:
Oregon with 20%,
Illinois with 10% - Customer with saved default shipping and billing address
Steps to reproduce
- create new order for the customer that already had a saved address in address book, Oregon with 20% tax rate in this case
- Uncheck "Same As Billing Address"
- Submit order
- Reorder that order
- Edit the shipping address state to Illinois
- Select shipping method
- Click Get Available Payment Method
Expected result
Tax should be kept as 10% following the new shipping state: Illinois
Actual result
Tax reverted to 20%
Additional information
I think this behavior was introduced in commit 629423a - [Cloud] reorder shipping zipcode does not update the latest shipping zip code. The intent was that, on Reorder, the shipping address picks up the latest data from the customer's address book. It does this by re-importing the address-book data on every quote save while the admin session is in "reordered" mode, without checking whether the admin has already edited the shipping address in the meantime.
Fortunatly, When "Submit Order" is clicked, the whole Create Order form is posted, including the full billing (and shipping) address data. `The order is therefore created with the edited address and the correct tax.
This only works because the addresses are re-posted on submit. Every AJAX block reload before that (select payment method, etc.) posts only partial data and runs a quote save, so the admin sees tax, totals and shipping rates calculated for the old address-book address until the moment of submit, this could confuse the admin.
Release note
No response
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.
- Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
- Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
- Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
- Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Activity
m2-assistant commentedon Oct 21, 2026
Hi @PhanQuocPhu. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.
@magento I am working on thisJoin Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
github-jira-sync-bot commentedon Oct 21, 2026
✅ Jira issue https://jira.corp.adobe.com/browse/AC-19524 is successfully created for this GitHub issue.
engcom-Bravo commentedon Oct 26, 2026
Hi @PhanQuocPhu,
Thanks for your reporting and collaboration.
We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Please refer the screenshot.
Tax should be kept as 10% following the new shipping state: Illinois.Could you please try to reproduce the issue in Latest 2.4-develop and elaborate the steps to reproduce if the issue is still reproducible.
Thanks.
PhanQuocPhu commentedon Oct 26, 2026
Tested again on latest commit, still facing it
Tax.Zones.and.Rates._.Taxes._.Stores._.Magento.Admin.mp4
bluefairydevelopment commentedon Oct 27, 2026
Reproduced on 2.4-develop. It needs the original order to be created in the admin with Same As Billing Address unticked, so its shipping address is saved to the address book. With an order placed another way it does not happen, which may be why it didn't reproduce earlier. The shipping-rates request doesn't send the "Select from existing customer addresses" value, so the quote keeps the saved address id after the fields are edited, and in reorder mode
SaveHandlerre-imports that address on the next save. Fix in #41722. Thanks PhanQuocPhu for the video.engcom-Bravo commentedon Oct 27, 2026
Hi @PhanQuocPhu,
Thanks for your Update.
We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.please refer the screenshot.
Tax reverted to 20%.Hence Confirming the issue.
Thanks.
github-jira-sync-bot commentedon Oct 27, 2026
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-19524